So for context: the reason why we are talking abou...
# meta-omics
j
So for context: the reason why we are talking about it is because we are not having enough reviewer activity at the pipeline level, and people are being put off doing reviews of MASSIVE PRs. So we are looking for mechanisms to get people to go smaller. So alternative suggestions welcome 🙂
m
more frequent releases?
👍 1
j
Reduce the requirements for review for
main
releases? Can still have the more stringent CI tests, but maybe only require a single review. Move a bit faster, and be more accepting of fast and small bugfix PRs?
j
More frequent releases isn't a mechanism @Maxime Garcia 😉 how do we get people to DO that more frequently
Can still have the more stringent CI tests, but maybe only require a single review.
I guess that could work, but we need to ensure it doesn't come from someone in the same project (the purpose of the release reviews is more to ensure we are still following the nf-core guidelines ... i.e. preventing bubbling)
Move a bit faster, and be more accepting of fast and small bugfix PRs?
How do we get people to do this?
j
I guess that could work, but we need to ensure it doesn't come from someone in the same project (the purpose of the release reviews is more to ensure we are still following the nf-core guidelines ... i.e. preventing bubbling)
Is there a way we can separate out a review that checks you're meeting nf-core guidelines from a review that checks the functionality of the code? --- Alternative that might be similar to "trunk based development" - instead of dev, have "feature branches" (e.g. for mag, long read only) that you merge PRs into. Then whenever you merge a feature branch to main you do a release?
👍 1
m
monthly automated released
j
That's honestly the thing I was thinking of tbh
Or every 3 PRs into dev RELEASE LETS GOOO
j
Monthly automated releases only works if you're not accumulating intermediate states in dev over time? Don't really want to release some half-baked refactor that has been split across multiple PRs for ease of review
m
I can finally make 3 releases a day
😆 1