<@U015PB15C5U> FYI I've dismissed your 'blocking' ...
# taxprofiler
j
@moritz FYI I've dismissed your 'blocking' review on https://github.com/nf-core/taxprofiler/pull/631 but re-requested the review. Generally we've realised blocking reviews (request changes) is not a good idea unless there is a severe problem. We have had lots of instances sporadic reviewers doing that and blocking progress (because tehy don't come back quickly to re-review). So as a PSA for everyone: if you review just leave 'comment review' unless you see a major problem! Regardless PRs cannot be merged in unless given an approving review ✅ so you don't have to worry about people getting confused and merging in too early!
m
Makes a lot of sense. And sorry for not taking another look sooner.
j
No worries!
Not your fault 🙂
It's more about differeing etiquette/practises in different places
👍 1
m
Helps to be clear about ways of working for sure.
❤️ 1