I’ve been wanting to make a first release for <#C0...
# pipeline-maintainers
j
I’ve been wanting to make a first release for #C0905QCFTPE https://github.com/nf-core/viralmetagenome/pull/207. However, I noticed that my conda tests are failing which are using the old workflow ci test setup (the one before this pr to tools https://github.com/nf-core/tools/pull/3469). I wanted to migrate more of my test setups to nf-test later. However has this become mandatory for pipeline release that all tests are within nf-test? If not, can some help me with this conda setup, seems like my issue is related to https://github.com/nextflow-io/nextflow/issues/5947, where I need to either patch nextflow minimum version or the conda version.
j
I figured out this week why I had been seeing this conda error, when other pipelines seemed to bypass it entirely. It looks like when conda environments are specified as a string “in-module” it fails, but when specified as an environment.yml file it doesn’t. The failing process in your test directly defines its conda environment: https://github.com/nf-core/viralmetagenome/blob/0edb69f3b56149fe6fd87a99c2ca67d312fa2bc4/modules/local/rename_fasta_header.nf#L5
j
ooh ok ... weird thanks a lot you probably saved me a day or 2 for finding that weird bug!
j
I only caught it by accident when writing a module test that imported a module with this issue... real lightbulb moment!
💡 1
f
Can we document this somewhere so people can find it? 🤔