<@U04JKRB6UUR> <@U02GS5HK553> I'm doing the templa...
# taxprofiler
j
@Lili Andersson-Li @Sofia Stamouli I'm doing the template merge - where we with nf-test? The template merge PR is failing as we don't have a snapshot...
s
Here is the PR. Lili has approved. I have not merged yet but is ready to go.
j
Ah completely missed that!
Did we discuss the approach for this?
s
No worries! I can merge now if you also approve
j
It's technically fine but just listing the files isn't really what we want (we want md5sums etc), but maybe we went with this just to get tests to psas on dev?
Is that correct?
And we do a follow up PR with an improved snapshot?
(I can't remember what we said now, sorry)
s
We did not discuss the approach but that was my understanding from hackathon, that we do a default snapshot first and the separate PRs for the rest.
j
OK!
So we will update this snapshto with the md5sum/string checks later?
IF so you can merge
and then I can pull in dev into the templtate merge
s
Yes, this is the hackathons approach, right?
I will merge now if so. Wanted to double check with you
👍 1
j
> Yes, this is the hackathons approach, right? Dependined on the context
(although my brain is a bit blurry about it now 😅 )
s
I think I can merge now and tomorrow I can look at the mdsums as the rest of the pipelines from hackathon.
j
OK!
s
Btw, just shared with you a folder where I am uploading the full melon database for whenever you have time
j
OK! Probs thursday 🙂
🙌 1