Naran
06/23/2025, 4:18 PM.tbi index, google/deepvariant also supports .csi index when the size of any reference chromosomes exceed 512M:
https://github.com/google/deepvariant/blob/r1.9/deepvariant/postprocess_variants.py#L1387-L1415
The changes I intend to push are described in issue#8694.
Shall I continue? I was thinking that many people use this module, and the change could cause linting/channel-calling problems to their local repository.Rike Hanssen
06/23/2025, 4:35 PMRike Hanssen
06/23/2025, 4:36 PMNaran
06/23/2025, 4:49 PMtbi, I can add index in meta.yml and main.nf as an optional output.
Thank you Rike! I'll update here when I create a PR.Simon Pearce
06/23/2025, 7:02 PMShall I continue? I was thinking that many people use this module, and the change could cause linting/channel-calling problems to their local repository. (edited)When people update the modules in their pipeline they should check to ensure that any changes to the module have don't break their downstream. Definitely update and improve the module, using
index instead of tbi seems perfect.Maxime Garcia
06/24/2025, 7:27 AMSimon Pearce
06/24/2025, 7:37 AMSimon Pearce
06/24/2025, 7:37 AMMaxime Garcia
06/24/2025, 7:38 AMSimon Pearce
06/24/2025, 7:40 AMArthur
06/24/2025, 9:13 AMtbi and csi channels with each being optional.
My personal opinion is that separate channels make understanding what is in them much clearer, allow for cases where the different channels might need to be handled differently without any complex parsing of args or file extensions.
So for example maybe I have .index and I need to do something different depending on whether I get csi or tbi - I would need to write some boilerplate like
DEEPVARIANT_RUNDEEPVARIANT.out.index
.branch{ meta, idx ->
csi: idx.name.tokenize('.')[-1] == 'csi'
tbi: idx.name.tokenize('.')[-1] == 'tbi'
}Arthur
06/24/2025, 9:22 AMSimon Pearce
06/24/2025, 9:44 AMArthur
06/24/2025, 9:46 AMArthur
06/24/2025, 9:48 AMSimon Pearce
06/24/2025, 9:50 AMMaxime Garcia
06/24/2025, 9:54 AMArthur
06/24/2025, 9:54 AMMaxime Garcia
06/24/2025, 9:56 AMMaxime Garcia
06/24/2025, 9:56 AMArthur
06/24/2025, 10:01 AMSHOULD and without someone militantly converting existing cases where no good reason to diverge exists, people just go with their preference. Also I think samtools/index and tabix/tabix both are separate and these are indexing modules people probably copy when unsure? (I know that's what I've done)Naran
06/26/2025, 12:53 PM.tbi if max_chromosome_length < 5e8, emits .csi if max_chromosome_length > 5e8.
Our case is that rundeepvariant moduleI currently limits the emit by naming it to be .tbi only, therefore we need to add a .csi.
It sounds like either use index universally; or name every format of index output, which is what Samtools/index module focuses on (creating different types of index) so it takes that effort.