Hello, I encountered a `nf-core linting` problem o...
# linting
n
Hello, I encountered a
nf-core linting
problem on a nf-core module `tabix/bgzip`: In
bgzip/meta.yml
line 43, there're single quote like this
Copy code
- '*.gzi':
However, nf-core linting/prettier want to change it to double quote
Copy code
- "*.gzi":
If it's changed, nf-core lint will complain that the module doesn't lint with the text message:
Copy code
Local copy of module does not match remote
Does anyone have problem similar like this? Is there anyway that I can pass the check by Prettier but not change the original content of
bgzip/meta.yml
Or is it better to update the
tabix/bgzip/meta.yml
file, and change to double quote. I can submit a PR about this.
m
Simplest solution imo: fix it upstream 🙂
👍 1
n
Yes! I'm thinking of submitting an issue to the bgzip module
m
Why not also a PR? Shouldn't be too difficult. I can give pointers if you need help 🙂
n
That will be great! Thank you so much ☺️. Let me read some instructions on how to submit a PR to the modules. Will reply here when I take actions.
Just created an issue: https://github.com/nf-core/modules/issues/8685 and forked the 'modules' repository. Not sure which branch I should work on though..
m
You can create a new one called whatever you want and then pushed the changes to your fork and open a pr against master
n
Done 🙂 Though I failed to do a test with
nf-test test bgzip/tests/main.nf.test --profile docker
It had a problem of reaching test data directory:
Copy code
Nextflow stdout:
ERROR ~ No such file or directory: nf-core/nf-core_modules/modules/nf-core/tabix/bgzip/.nf-test/tests/8d28a85252b9c46436b95483186b9c9b/nullgenomics/homo_sapiens/genome/genome.bed.gz
I'm looking into it right now.
Hi Mashehu, just saw you approved my PR https://github.com/nf-core/modules/pull/8687. Thank you so much! I tried to update my branch with master just then. Was it a wrong thing to do? Cuz I saw the required tests need to repeat again..
m
No, it was fine to update the branch. In order to automatically trigger the CI checks you would need to be part of the nf-core org on github ( #CEB982K2T), but I added it now to the merge queue so it should be merged soon anyway
❤️ 1
n
That’s great. Thank you!
m
thanks for the fix!
nf core zoom 1