Hi all, we had <discussion> over in <#CJRH30T6V|> ...
# team-maintainers
f
Hi all, we had discussion over in #CJRH30T6V regarding Dockerfiles for nf-core modules those tools are not on Bioconda, and specially this guideline. TL;DR is the question when we should require a Dockerfile for modules and what should be the content of this file? The example of DeepVariant was brought up, which has no Dockerfile in the modules repository. Another problematic case are the force modules from #C068T3R7LAE, where using the original tool's Dockerfile is not feasible because it requires additional files from the tool repository to be build, and we probably don't want to add these files in the modules repo. We have a copy of the force image (dockerhub) at quai.io. Thus, we could use a Dockerfile containing either only:
Copy code
FROM davidfrantz/force:3.8.01
, which maintains the link to the original tool but could also be defunct when the image is removed, or only
Copy code
FROM <http://quay.io/nfcore/force:3.8.01|quay.io/nfcore/force:3.8.01>
p
The intention of the Dockerfile is essentially to provide documentation so that the custom image can be updated / rebuilt etc. in the future.
this 3
I'm sure it'd be fine to add a Readme or similar describing the origin of a Dockerfile doesn't make sense.
this 1
We just want to avoid individual contributors building images, then others in the future being unable to maintain them.
s
I think having the Dockerfile that says that it is coming from
FROM davidfrantz/force:3.8.01
is absolutely fine. As Phil says, that means that we know how the image was built. If the external github goes down, then we still have the copy of the image, so we have a backup. If it needed to be rebuilt and extended then someone would have to take over the (external to nf-core) project and do that.