Hi team, I have a PR that could use some opinions:...
# team-maintainers
i
Hi team, I have a PR that could use some opinions: PR. While it has a lot of simple issues that I have addressed in the review, there are some points on which I would like to get a second opinion. 1. README. I lean towards not allowing it, as it will only live in the repo and not be available on the website in any form. However, a more human-centric description of the module is not entirely wrong. 2. Mini-workflow. I know we have discussed it before, but no consensus was ever reached. It might be a useful feature for some. However, the way it is used in this PR (testing) is certainly incorrect.
m
ad 1) you are 100% correct there.
j
Left a couiple of comments
f
For 1) I was wondering whether we could add something like a "notes" field to the meta map? Mabye some hints on how to add specific flags (if they are not required params)
👍 1
m
like
help_text
in nextflow_schema.json?
f
yeah something like that, because I realized that sometimes I would like to add a short description on how to add specific flags to the tool that people might want to set in the modules.config
👍 1
j
Yeah that might be nice
I currently prompt people to put it in the inputs or descritopion but it's a little suboptima;l
m
you can use markdown in the description including admonitions in case you want to give it some info hierarchy
👀 1
s
There are a number of modules that we've ended up with some kind of note somewhere, to make it clear of some kind of limitation
Note that the test is currently trying to use the old style of pytest rather than nf-test.
😬 1
shakefist 1
i
I wondered where they got this weird format
s
AI?
excuseme 1
ai thumbsup 2
i
Feels almost impossible with over 99% of the modules converted to nf-test, unless ChatGPT was involved
s
There is one subworkflow that still needs converting, because it doesn't currently work
all the modules are converted
i
Okay, then must be the water AI