<@UQWKJ27RQ> suggested I replace all my references...
# meta-omics
d
@Daniel Straub suggested I replace all my references to
params.outdir
with
$outputDir
which I agreed with at first. When I check the code, however, I see that I got this from the template, e.g.
def stable_path = getAllFilesFromDir(params.outdir, ignoreFile: 'tests/.nftignore')
. But there's also
removeNextflowVersion("$outputDir/pipeline_info/nf_core_metatdenovo_software_mqc_versions.yml")
. Since
params.outdir
is set in the
when
clause, I suppose it's equivalent, but I'd like to be consistent. (Which conflicts with my wish to have as few merge conflicts as possible in the next template update.)
@James Fellows Yates made a PR that's related: https://github.com/nf-core/tools/issues/3614
d
Sorry again I didnt see that in time. Too many communication channels...
d
Not targeted directly to you, but to anyone with an opinion.
d
I saw that in https://deploy-preview-3387--nf-core-docs.netlify.app/docs/tutorials/tests_and_test_data/components/06_testing_pipelines#best-practic[…]or-nft-utils quote: Best Practices for nft-utils 1. Always set outdir to
$outputDir
- ensures consistent test directory structure
But whatever works 😉
d
I interpret that as what's in the
when
block of the template. But, I agree, no big deal for me and I'll be resting my case until someone makes a decision.
d
Ah yes, maybe its rather about the when block