Because I'm trying to 100% my linting for <#C062H8...
# tools
j
Because I'm trying to 100% my linting for #createtaxdb
Copy code
╭─ [!] 15 Subworkflow Test Warnings ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                    ╷                                                               ╷                                                                  │
│ Subworkflow name                   │ File path                                                     │ Test message                                                     │
│╶───────────────────────────────────┼───────────────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────╴│
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'completionEmail' not used in main.nf         │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'completionSummary' not used in main.nf       │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'imNotification' not used in main.nf          │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'paramsSummaryMap' not used in main.nf        │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'UTILS_NEXTFLOW_PIPELINE' versions are not    │
│                                    │                                                               │ added in main.nf                                                 │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'UTILS_NFCORE_PIPELINE' versions are not      │
│                                    │                                                               │ added in main.nf                                                 │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'UTILS_NFSCHEMA_PLUGIN' versions are not      │
│                                    │                                                               │ added in main.nf                                                 │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'completionEmail' versions are not added in   │
│                                    │                                                               │ main.nf                                                          │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'completionSummary' versions are not added in │
│                                    │                                                               │ main.nf                                                          │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'imNotification' versions are not added in    │
│                                    │                                                               │ main.nf                                                          │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'paramsSummaryMap' versions are not added in  │
│                                    │                                                               │ main.nf                                                          │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/main.nf  │ Included component 'samplesheetToList' versions are not added in │
│                                    │                                                               │ main.nf                                                          │
│ preprocessing                      │ subworkflows/local/preprocessing/meta.yml                     │ Included module/subworkflow seqkit/batch/rename missing in       │
│                                    │                                                               │ meta.yml                                                         │
│ utils_nfcore_createtaxdb_pipeline  │ subworkflows/local/utils_nfcore_createtaxdb_pipeline/meta.yml │ Subworkflow meta.yml does not exist                              │
│ generate_downstream_samplesheets   │ subworkflows/local/generate_downstream_samplesheets/main.nf   │ Subworkflow does not include any modules before the workflow     │
│                                    │                                                               │ definition                                                       │
│                                    ╵                                                               ╵                                                                  │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
Are all these
utils_nfcore_createtaxdb_pipelin
warnings valid here? They are from the template so I'm confused why the linter would complain against tehmselves? Also for the last one for the 'does not include any modules' - I gave a purely nextflow code subworkflow... is there a reason that is not valid ?
a
Subworkflow linting is limited to put it politely. A lot of assumptions are made about them and whilst they generally work fine, particularly for the subworkflows in the nf-core remote, they don’t always make much sense for local subworkflows in particular (and a recent update by someone 😬) aligned local subworkflow/module format to remote format. Most of the warnings around
utils_nfcore_createtaxdb_pipeline
can probably be safely ignored but you do have some potentially valid ones around e.g.
subworkflows/local/preprocessing/meta.yml
😬 1
j
Yeah the preprocessing was the only valid one
But I missed it first time around because it was buried in all the others...
OK, I guess I can't 100% this for now 😞
sad panda
a
I don’t know if it’s possible to ignore linting for a specific subworkflow but I suspect
utils_nfcore_<name>_pipeline
either needs some special treatment or totally ignoring as it is somewhat of a special case subworkflow
j
Exactly, that's what I assumed should be happening already but I guess not