James Fellows Yates
06/05/2025, 8:28 AMnf-test test command to generate the snapshot is misleading:
• It will trigger tests for every single module too (unwanted)
• There is not a default container system profile, so it first fails for missing that
• Instinctively people will add --profile docker to the nf-test command, but this fails as it overwrites all over test configs
We suggest:
nf-test test --tag pipeline --profile=+<docker/singularity/conda etc.>
Where --tag pipeline makes sure you only run the default.nf.test test, and --profile=+docker specifies to run docker but in an additive manner (so does not overwrites any test.configs that are being used)Maxime Garcia
06/05/2025, 8:29 AMnf-test test tests/ --profile=+<docker/singularity/conda etc.>mashehu
06/05/2025, 8:46 AMJames Fellows Yates
06/05/2025, 8:53 AMJames Fellows Yates
06/05/2025, 8:58 AMJames Fellows Yates
06/05/2025, 8:59 AMnf-test.yml runs EVERY SINGLE test in teh entire pipeline?!mashehu
06/05/2025, 9:05 AMJames Fellows Yates
06/05/2025, 9:07 AMJames Fellows Yates
06/05/2025, 9:08 AMJames Fellows Yates
06/05/2025, 9:08 AMmashehu
06/05/2025, 9:08 AMJames Fellows Yates
06/05/2025, 9:08 AMJames Fellows Yates
06/05/2025, 9:08 AMmashehu
06/05/2025, 9:08 AMmashehu
06/05/2025, 9:09 AMJames Fellows Yates
06/05/2025, 9:09 AMJames Fellows Yates
06/05/2025, 9:09 AMJames Fellows Yates
06/05/2025, 9:09 AMipeline_if_empty_null take such a long time during linting?James Fellows Yates
06/05/2025, 9:12 AMNo, the modules should not run.I don't think there is any part in
nf-test.yml or action.yml where you limit to just e.g. pipeline tagsJames Fellows Yates
06/05/2025, 9:12 AM- name: Run nf-test
uses: ./.github/actions/nf-test
env:
NFT_DIFF: ${{ env.NFT_DIFF }}
NFT_DIFF_ARGS: ${{ env.NFT_DIFF_ARGS }}
NFT_WORKDIR: ${{ env.NFT_WORKDIR }}
with:
profile: ${{ matrix.profile }}
shard: ${{ matrix.shard }}
total_shards: ${{ env.TOTAL_SHARDS }}James Fellows Yates
06/05/2025, 9:34 AMJames Fellows Yates
06/05/2025, 9:34 AM> Loading ncbi.tre: OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x00007fd266000000, 16877879296, 0) failed; error='Not enough space' (errno=12)
> #
> # There is insufficient memory for the Java Runtime Environment to continue.
> # Native memory allocation (mmap) failed to map 16877879296 bytes for committing reserved memory.
> # An error report file with more information is saved as:
> # hs_err_pid33.logJames Fellows Yates
06/05/2025, 9:35 AMJames Fellows Yates
06/05/2025, 9:36 AMJames Fellows Yates
06/05/2025, 10:37 AM(also why does ipeline_if_empty_null take such a long time during linting?This appears tobe only locally though
mashehu
06/05/2025, 10:37 AMmashehu
06/05/2025, 10:38 AMMaxime Garcia
06/05/2025, 10:43 AMignore 'modules/nf-core/**/tests', 'subworkflows/nf-core/**/tests'James Fellows Yates
06/05/2025, 10:44 AMJames Fellows Yates
06/05/2025, 10:44 AMMaxime Garcia
06/05/2025, 10:44 AMJames Fellows Yates
06/05/2025, 10:44 AMpipelineMaxime Garcia
06/05/2025, 10:45 AMMaxime Garcia
06/05/2025, 10:45 AMJames Fellows Yates
06/05/2025, 10:45 AMmashehu
06/05/2025, 10:46 AMMaxime Garcia
06/05/2025, 10:46 AMMaxime Garcia
06/05/2025, 10:46 AMMaxime Garcia
06/05/2025, 10:46 AMJames Fellows Yates
06/05/2025, 10:47 AMJames Fellows Yates
06/05/2025, 10:48 AMMaxime Garcia
06/05/2025, 10:49 AMMaxime Garcia
06/05/2025, 10:49 AMMaxime Garcia
06/05/2025, 10:49 AMJames Fellows Yates
06/05/2025, 10:49 AMMaxime Garcia
06/05/2025, 10:49 AMJames Fellows Yates
06/05/2025, 10:49 AMJames Fellows Yates
06/05/2025, 10:50 AMJames Fellows Yates
06/05/2025, 10:50 AMJames Fellows Yates
06/05/2025, 10:50 AMmashehu
06/05/2025, 10:50 AMnf-test-detect-changes no?James Fellows Yates
06/05/2025, 10:51 AMJames Fellows Yates
06/05/2025, 10:51 AMMaxime Garcia
06/05/2025, 10:52 AMMaxime Garcia
06/05/2025, 10:53 AM// list of filenames or patterns that should be trigger a full test run
triggers 'nextflow.config', 'nf-test.config', 'conf/test.config', 'tests/nextflow.config', 'tests/.nftignore'James Fellows Yates
06/05/2025, 10:53 AMJames Fellows Yates
06/05/2025, 10:53 AMMaxime Garcia
06/05/2025, 10:53 AMJames Fellows Yates
06/05/2025, 10:53 AMJames Fellows Yates
06/05/2025, 10:53 AMJames Fellows Yates
06/05/2025, 10:53 AMmashehu
06/05/2025, 10:54 AMMaxime Garcia
06/05/2025, 10:54 AMJames Fellows Yates
06/05/2025, 10:54 AMThings are documented, I would say we need to improve the documentationWhere?
mashehu
06/05/2025, 10:54 AMJames Fellows Yates
06/05/2025, 10:55 AMMaxime Garcia
06/05/2025, 10:55 AMWhere?Comments are documentation
James Fellows Yates
06/05/2025, 10:56 AMJames Fellows Yates
06/05/2025, 10:56 AMJames Fellows Yates
06/05/2025, 10:56 AM// ignore tests coming from the nf-core/modules repo
Is not whyJames Fellows Yates
06/05/2025, 10:57 AMComment your code. Each line of a comment should begin with the comment symbol and a single space: #. Comments should explain the why, not the what.http://adv-r.had.co.nz/Style.html
James Fellows Yates
06/05/2025, 10:58 AMignore 'modules/nf-core/**/tests', 'subworkflows/nf-core/**/tests'James Fellows Yates
06/05/2025, 10:58 AMMaxime Garcia
06/05/2025, 10:59 AMJames Fellows Yates
06/05/2025, 10:59 AMMaxime Garcia
06/05/2025, 10:59 AMAnd @Maxime Garcia this line is not working:How is this not working?
James Fellows Yates
06/05/2025, 10:59 AMJames Fellows Yates
06/05/2025, 10:59 AMJames Fellows Yates
06/05/2025, 11:00 AMJames Fellows Yates
06/05/2025, 11:00 AMignore 'modules/nf-core/**/tests/*', 'subworkflows/nf-core/**/tests/*'
nowMaxime Garcia
06/05/2025, 11:00 AMJames Fellows Yates
06/05/2025, 11:05 AMMaxime Garcia
06/05/2025, 11:11 AMMaxime Garcia
06/05/2025, 11:11 AMMaxime Garcia
06/05/2025, 11:11 AMtests/?James Fellows Yates
06/05/2025, 11:12 AMMaxime Garcia
06/05/2025, 11:30 AMJames Fellows Yates
06/05/2025, 11:30 AMJames Fellows Yates
06/05/2025, 11:30 AMJames Fellows Yates
06/05/2025, 11:30 AMJames Fellows Yates
06/05/2025, 11:31 AMMaxime Garcia
06/05/2025, 11:34 AMMaxime Garcia
06/05/2025, 11:34 AMJames Fellows Yates
06/05/2025, 11:35 AMJames Fellows Yates
06/05/2025, 11:35 AMMaxime Garcia
06/05/2025, 11:35 AMJames Fellows Yates
06/05/2025, 11:38 AMJames Fellows Yates
06/05/2025, 11:38 AMJames Fellows Yates
06/05/2025, 11:39 AMMaxime Garcia
06/05/2025, 11:41 AMmashehu
06/05/2025, 12:50 PMJames Fellows Yates
06/05/2025, 1:07 PM/tests dir at the end of the ignore listJames Fellows Yates
06/05/2025, 1:07 PM