Sooo I've now hit an instance where I want to depr...
# team-maintainers
j
Sooo I've now hit an instance where I want to deprecate a module... I vaugely remember some people wanting to do more than just https://nf-co.re/docs/guidelines/components/module_deprecation (@Simon Pearce @Mahesh Binzer-Panchal was that you?) what were those things (IIRC)?
s
There were a couple of modules that were deleted as they had only been made a few days before (to rename them), but otherwise I've deprecated modules as stated there.
👍 1
j
Ahh ok, then I guess we could update it's ok to delete if very soon after creation but otherwise stick with what we have 👍
👍 1
m
Yeah. Exactly. Nothing more from my side
j
Nice 🙂
Just to check: we definitely expect to merge the deprecation module even if the module fails in the nf-test runs?
I think we forgot to update the docs what to do about the failing test. I think we just change the test to failed
j
so ` { assert
process.success },
?
And remove all other assertions?
m
assert process.failed
I think it is because the
assert
in the
process
will make it always fail
Copy code
{ assert process.failed }
j
I just opened that exact one 🙂
Do you have time to update the docs? Then I can test it
m
Sure
j
❤️
m
j
testing...