are we ok to merge in <https://github.com/nf-core/...
# team-maintainers
m
are we ok to merge in https://github.com/nf-core/modules/pull/7518? there's an extra conda channel for the recipe, which makes linting fails
👍 2
💯 1
👍🏻 1
p
Pretty sure you could have got linting to pass by removing it from
channels
at the top and prepending it to the package name
Instead of:
Copy code
channels:
- ome
- conda-forge
- bioconda
dependencies:
- ome::bioformats2raw=0.9.4
just:
Copy code
channels:
- conda-forge
- bioconda
dependencies:
- ome::bioformats2raw=0.9.4
I think it'd work fine
That said, not sure that we want to / need to limit the conda channels? Seems a little restrictive, especially with more non-bioinfo pipelines coming in.. Should maybe just check that
defaults
isn't there? https://github.com/nf-core/modules/blob/b18c491fc0334e699edd51be8ff2b6950c748d54/modules/environment-schema.json#L7-L13
m
How about having required conda-forge, forbidden defaults and anything else is optional (including bioconda) ?
p
Would be fine by me 👍🏻
m
I think having bioconda optional sounds like a good future proof plan with us expanding outside of biology
💯 1
m
what’s the reason for requiring conda-forge and not just allowing everything except default? asking for a PR https://github.com/nf-core/modules/pull/8554
m
From my own point of view, I assume
conda-forge
is a good default channel to have
p
I guess it can be a default (in the template) without being required
👍🏻 1
m
I think, having conda-forge required is a good practice since most of the things we use are from bioconda, and it's a requirement, no?
😉
m
Touché
ok, I'm all for it then
Using my own words against me
How dare you?
m
shared a GIF
🤣 1