It feels like v3.2.1 breaks nf-test, anyone had th...
# pipeline-maintainers
k
It feels like v3.2.1 breaks nf-test, anyone had the same issue? or am I missing something https://github.com/nf-core/variantbenchmarking/pull/193/files
👀 1
m
nf-test: command not found
k
yeap
m
I don't see why
I have not seen this
k
nf-test installation is being deleted with the new update
m
oh yeah
This would be coming with the next template in a new file
BTW, you actually have the same error in the other latest-everything as well, which would make sense
but no error
k
on my other PRs? that was why I wanted to get the update 😮‍💨
m
on this same PR
k
I just realize it.. yea it doesnt run but signal is green
m
that's it
but you found the solution, just restore nf-test + pdiff install in your
ci.yml
file, and you'll be good
Did you do anything to have no error on latest-everything?
k
m
yeah, that should not results in no error for these tests
and you still have
nf-schema@2.3.0
in your PR
k
ach, that was for my other PR
it was not in dev
then how 🤣
m
I'm so confused dog
k
me too :D
is this expected?
I mean tests are not running
🤯 1
🤣 1
m
LOOOL
I'm impressed
can you try
nf-core pipelines lint
locally?
k
Copy code
ERROR    Pipeline repository not found in /tmp/tmp71n5z3nd/nf-core-variantbenchmarking
okay I break everything
m
yeah
k
Copy code
actions_schema_validation: Workflow validation failed for ci.yml: {'name': 'Run pipeline with test data ${{ matrix.NXF_VER }} | ${{ matrix.test_name }} | ${{ matrix.profile }}', 'continue-on-error': "${{ matrix.NXF_VER == 'latest-everything' }}"} is not valid under any of the given schemas                                                                                                                                            │
│                                                                                                                                                                                                                                                                                                                                                                                                                                               │
│ Failed validating 'oneOf' in schema[0]['properties']['steps']['items']: {'type': 'object', 'additionalProperties': False, 'dependencies': {'working-directory': ['run'], 'shell': ['run']}, 'oneOf': [{'required': ['uses']}, {'required': ['run']}], 'properties': {'id': {'$comment': '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepsid>',               │
│ 'description': 'A unique identifier for the ' 'step. You can use the id to ' 'reference the step in contexts. ' 'For more information, see ' '<https://help.github.com/en/articles/contexts-and-expression-syntax-for-github-actions.>', 'type': 'string'}, 'if': {'$comment': '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepsif>', 'description': 'You can  │
│ use the if conditional ' 'to prevent a step from running ' 'unless a condition is met. You ' 'can use any supported context ' 'and expression to create a ' 'conditional.\n' 'Expressions in an if ' 'conditional do not require the ' '${{ }} syntax. For more ' 'information, see ' '<https://help.github.com/en/articles/contexts-and-expression-syntax-for-github-actions.>', 'type': ['boolean', 'number', 'string']}, 'name':             │
│ {'$comment': '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepsname>', 'description': 'A name for your step to ' 'display on GitHub.', 'type': 'string'}, 'uses': {'$comment': '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepsuses>', 'description': 'Selects an action to │
│ run as ' 'part of a step in your job. ' 'An action is a reusable unit ' 'of code. You can use an ' 'action defined in the same ' 'repository as the workflow, a ' 'public repository, or in a ' 'published Docker container ' 'image ' '(<https://hub.docker.com/>).\n' 'We strongly recommend that ' 'you include the version of ' 'the action you are using by ' 'specifying a Git ref, SHA, or ' 'Docker tag number. If you ' "don't specify │
│ a version, it " 'could break your workflows or ' 'cause unexpected behavior ' 'when the action owner ' 'publishes an update.\n' '- Using the commit SHA of a ' 'released action version is ' 'the safest for stability and ' 'security.\n' '- Using the specific major ' 'action version allows you to ' 'receive critical fixes and ' 'security patches while still ' 'maintaining compatibility. It ' 'also assures that your ' 'workflow   │
│ should still work.\n' '- Using the master branch of ' 'an action may be convenient, ' 'but if someone releases a new ' 'major version with a breaking ' 'change, your workflow could ' 'break.\n' 'Some actions require inputs ' 'that you must set using the ' 'with keyword. Review the ' "action's README file to " 'determine the inputs ' 'required.\n' 'Actions are either JavaScript ' 'files or Docker containers. ' "If the action   │
│ you're using is " 'a Docker container you must ' 'run the job in a Linux ' 'virtual environment. For more ' 'details, see ' '<https://help.github.com/en/articles/virtual-environments-for-github-actions.>', 'type': 'string'}, 'run': {'$comment': '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepsrun>', 'description': 'Runs command-line programs '      │
│ "using the operating system's " 'shell. If you do not provide a ' 'name, the step name will ' 'default to the text specified ' 'in the run command.\n' 'Commands run using non-login ' 'shells by default. You can ' 'choose a different shell and ' 'customize the shell used to ' 'run commands. For more ' 'information, see '                                                                                                             │
│ '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#using-a-specific-shell>.\n' 'Each run keyword represents a ' 'new process and shell in the ' 'virtual environment. When you ' 'provide multi-line commands, ' 'each line runs in the same ' 'shell.', 'type': 'string'}, 'working-directory': {'$ref': '#/definitions/working-directory'}, 'shell': {'$ref':               │
│ '#/definitions/shell'}, 'with': {'$comment': '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepswith>', '$ref': '#/definitions/env', 'description': 'A map of the input parameters ' 'defined by the action. Each ' 'input parameter is a ' 'key/value pair. Input ' 'parameters are set as ' 'environment variables. The ' 'variable is prefixed with '       │
│ 'INPUT_ and converted to upper ' 'case.', 'properties': {'args': {'$comment': '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepswithargs>', 'type': 'string'}, 'entrypoint': {'$comment': '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepswithentrypoint>', 'type':         │
│ 'string'}}}, 'env': {'$comment': '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepsenv>', '$ref': '#/definitions/env', 'description': 'Sets environment variables for ' 'steps to use in the virtual ' 'environment. You can also set ' 'environment variables for the ' 'entire workflow or a job.'}, 'continue-on-error': {'$comment':                      │
│ '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepscontinue-on-error>', 'description': 'Prevents a job ' 'from failing ' 'when a step ' 'fails. Set to ' 'true to allow a ' 'job to pass when ' 'this step fails.', 'oneOf': [{'type': 'boolean'}, {'$ref': '#/definitions/expressionSyntax'}], 'default': False}, 'timeout-minutes': {'$comment':             │
│ '<https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepstimeout-minutes>', 'description': 'The maximum number ' 'of minutes to run ' 'the step before ' 'killing the ' 'process.', 'oneOf': [{'type': 'number'}, {'$ref': '#/definitions/expressionSyntax'}]}}}                                                                                                     │
│                                                                                                                                                                                                                                                                                                                                                                                                                                               │
│ On instance['steps'][7]: {'name': 'Run pipeline with test data ${{ matrix.NXF_VER }} | ${{ ' 'matrix.test_name }} | ${{ matrix.profile }}', 'continue-on-error': "${{ matrix.NXF_VER == 'latest-everything' }}"}                                                                                                                                                                                                                              │
│
m
I'll make suggestions to your ci.yml
k
sorry that was tooooo long
not sure if this will fix something, but you modified the ci.yml, since it's different form the template these lines don't make sense here
m
Made some suggestions, that should solve your current issues
👍🏻 1
🙏🏻 1
🙏 1
k
I am commiting Maximes changes
🎉 1
m
you know you can commit batch from Github?
k
yey, tests are back
🎉 1
that is why I did :)
m
Thanks for the sidequest, that was fun
k
thanks to you :)) you again saved my template update 🤣
m
Always happy to help out
❤️ 2