Charles Plessy
04/26/2025, 12:14 AMsamtools/bgzip (https://github.com/nf-core/modules/pull/7433), does one more person would like to have a check and press the merge button if everything is all right?Maxime Garcia
04/28/2025, 6:55 AM.bgzip.fa.gz seems like a bit too big of an extension.
https://github.com/nf-core/modules/blob/master/modules/nf-core/tabix/bgzip/main.nf for example only produces .gz.
I'd rather we keep the extension short, and don't expect people to use fa while they might be using fasta and so onCharles Plessy
04/28/2025, 7:07 AMMaxime Garcia
04/28/2025, 7:15 AMCharles Plessy
05/07/2025, 7:06 AM${prefix}.gz for the output name. If the file was already BGZIPped under this name, it will just output the file itself. If the file was gzipped but not in BGZIP format and already had this name, it will error with a shell return code of 1 and a message mentioning the file name conflict. If the file happened to be gzipped (non-BGZIP), and had an erroneous name file extension (such as using .gz for XZ compression etc.), the module will crash without a useful error message, but I expect this to be extremely rare.Maxime Garcia
05/07/2025, 7:48 AMIf the file was already BGZIPped under this name, it will just output the file itselfOK, so people could be smart and check the file before running the modules
Maxime Garcia
05/07/2025, 7:49 AMCharles Plessy
05/08/2025, 4:54 AMMaxime Garcia
05/08/2025, 8:16 AMMaxime Garcia
05/08/2025, 8:16 AMMaxime Garcia
05/08/2025, 8:16 AMMaxime Garcia
05/08/2025, 8:16 AMCharles Plessy
05/08/2025, 8:34 AMMaxime Garcia
05/08/2025, 8:39 AMCharles Plessy
05/08/2025, 8:39 AMMaxime Garcia
05/08/2025, 8:44 AM