Can someone help me understand why the linter want...
# tools
e
Can someone help me understand why the linter wants me to do this change, which doesn't make sense to me? https://github.com/nf-core/modules/pull/8272#issuecomment-2809059747
j
the important changes in this message that you show are the addition of the field
ontologies
you can ignore the others which are changing the type and description
e
I hope it will pass linting, because it failed on the CI
j
if it fails you can send a link of the failing test so I can see the error message there
it's a bit difficult to follow the changes from the git diff in the comment
e
Ok, one sec
Basically that diff is what
nf-core lint --fix
does, but it doesn't make sense at a first glance
(dev version, but that's what runs on the CI, 3.2.0 does not have linting issues)
j
it's the
ontologies
key and one extra channel that you had due to a but, we fixed it now on dev
do you want me to push the changes on your PR?
e
If it's allowed, I have no idea how to allow edits
Alternatively drop a diff here if all else fails
j
ah right, I don't have acces 😄
e
If you can just make a diff I'll apply locally and push (drop the GH username as well so I can credit you)
j
if you remove this part, it should pass linting
Copy code
- ues_csv:
          type: file
          description: |
            CSV file containing amplification p-values. Optional
          pattern: "*_amplification_pvalues.csv"
e
The `pvalues_csv" entirely?
Oh
I saw
it was duplicated
It passes, thanks!
👏🏻 1