Matthias Zepper
04/04/2025, 8:38 AMdev_download branch directly on the #tools repo instead of my own fork?
I am asking, because I think it is the best way forward to resolve a stalemate regarding the pull requests 3509, 3517, 3506, and Julians work. Not being particular familiar with the nf-core naming conventions, I made the decision to refactor the code into a folder download*s* instead of download and instructed all Hackathon participants accordingly.
Using downloads prevented import errors that otherwise occurred due to namespace collisions between nf_core/pipelines/download.py and nf_core/pipelines/download/__init__.py
ImportError: cannot import name 'DownloadWorkflow' from 'nf_core.pipelines.download'
Now, during review of PRs 3509 and 3506 this decision haunts me, because it was rejected. But all those PRs are dependent on each other and any change in the file and test structure will inevitably create huge merge conflicts.
We seemingly have already lost momentum by this stalemate and I do not want to let the branches go stale, because they represent significant work by the Hackathon participants.
Therefore, I suggest that we create a new branch dev_download, which to which we will change the base of those PRs. Here, we can merge in imperfect PRs that are maybe not fit for dev, but then do not have to address all issues directly. I will polish this branch later for dev, but really would like to merge the current PRs in the near future to have the new framework set up. Running git mv later on one branch will be relatively straightforward compared to refactoring 4 interdependent PRs because of a single letter that I got wrong.Júlia Mir
04/04/2025, 8:46 AM