Can anyone remember where the documentation is abo...
# team-maintainers
j
Can anyone remember where the documentation is about not using lots of baked-in-assumptions on meta fields? This one has... issues https://github.com/nf-core/modules/pull/7750
Although isn't there some other extremely nasty module that has done something similar @Rike Hanssen?
j
That's it- thanks!
r
sorry I am out at the moment.
controlfreec is a module with crazy configuration
j
I think that's the one!
s
Yeah, there are maybe ~20 or so modules with non-standard meta fields
j
But we're attempting to fend off too many new ones, right?
💯 4
r
ok took a look. controlfreec does not use custom meta data fields
I really think we should discourage this as much as possible
j
Ah ASCAT was the one I thought it was
But yeah, custom meta fields are bad
I know people pushback on this but it definitely cause problems
j
This is a differential module in the vein of deseq2 and it's being used in the same context, so it really should use the same approach- mandatory strings via specific channel elements.
👍 1
r
yep now that the rules changed to pass in mandatory arguments that should anyways be the solution (as much as I don't love it 😄 )
👍 1
j
What would your preferred solution be actually?
r
I love keeping the params all together in the modules.config. Personally I just find it easier to understand what another pipeline runs and what they plan to cal the tool with. I don't love that parameters are now defined in several places if I just want to understand a pipeline
j
Ahhh yeah
r
It makes tracking things through a lot harder imo
j
I am with you on that one
But @Simon Pearce @Mahesh Binzer-Panchal really REALLY wanted this 'minmum to get the pipeline to run' thing
pinging them in risk of
(insert gif of opening pandoras box her as DB wifi...)
pandoras box
r
I don't want to derails the discussion here though
j
I believe I was on 'team channel' also. Let's not reopen the conflict though 😭
r
the guidelines at the moment are what they are. let's focus on the issue at hand
❤️ 1
m
hisat2 has params homer disappear
m
So my opinion is that module needs to be corrected to remove those custom meta fields. If they're required add them in as
val
inputs. This way they're also documented in the
meta.yml
too. It's already difficult enough to connect things without realising there are undocumented inputs in the module too.
this 1
👍 4
m
The wizard has spoken
💯 1
f
Maybe we can add this approach to the docs? Because now this makes sense to me
➕ 1
j
Which approach?
(but yes MORE DOCS!)
f
Like the one with not overloading the meta map but instead adding value channels
j
That's already documented
paranoid 1
(so 1.4 an d 1.6)
f
But there is no word on val?
ah nvm
I just had a look at the module and there is a nextflow.config file that is not even used in the test. But I guess its merged now anyway and is not such a big file. But I would be careful letting files in that are not used 🙂
👍 1
s
Ascat's extremely weird list args is a whole separate kettle of fish 😉
💯 1
m
kettle of fish?
🐟 1
s
a real mess
The expression "a kettle of fish" means "a real mess." If you accidentally scheduled three dates on the same night, you might call it a kettle of fish. Most people who use this expression say either "a fine kettle of fish" or "a pretty kettle of fish," though what they're describing isn't fine or pretty.
🐟 1
m
I wasn't aware of this expression, thanks Simon
s
a different kettle of fish
phrase
If you say that something is a different kettle of fish, you mean that it is very different from another related thing that you are talking about.
[informal]
Playing for the reserve team is a totally different kettle of fish.
basically I'm using it here to mean something that is annoying/messy/difficult, but it isn't directly related to this current one 😉
j
At the risk of completely derailing things, I like a good game of 'compare the idiom'. What's the French equivalent @Maxime Garcia?
🤣 1
m
so for be a fine kettle of fish could be
dans de beaux draps
-> in fine bedsheets
And since when are you derailing things?
🤷 1
dans le pétrin
-> (pétrin is the tool/place used to knead the dough for making bread)
thankyou 1
❤️ 1
j
I feel a random Maxime slack channel opening up 😆
m
you asked for it
-> #derailing-conversations
j
Basically a sin bin into which off-topicers can be banished
party this 3