Matthias Zepper
03/25/2025, 10:30 AMcls_workflow_repo.py for a file that will essentially hold a single class to be used by several subtools related to downloads. We have a legacy file called synced_repo.py that has a quite similar functionality elsewhere.
Do you think using a prefix like cls_ to make clear that this file contains a class that is imported into other parts of the code is 👍 or rather 👎?Júlia Mir
03/25/2025, 10:33 AMMatthias Zepper
03/25/2025, 10:46 AMdownloads.py is currently a 2000 lines long file that defines several classes with relevance also to other code.
But because nobody is looking for a generally applicable useful class there when doing something unrelated, it will not be found. mashehu for example wrote the PipelineRepo class in utils.py , even though the preexisting WorkflowRepo in downloads.py would probably have worked for this use case as well. I do not know his rationale - maybe it was a deliberate decision, maybe he just wasn’t aware of WorkflowRepo.
Arguably, one could have put it to utils.py instead, but a huge utils is equally hard to navigate. Therefore, I am sympathetic moving classes with a general applicability to separate files each. In this way, I hope to reduce code duplication and make them easier to discover?Matthias Zepper
03/25/2025, 10:47 AMJúlia Mir
03/25/2025, 10:49 AMJúlia Mir
03/25/2025, 10:49 AMJúlia Mir
03/25/2025, 10:49 AMArthur
03/25/2025, 11:33 AMMatthias Zepper
03/25/2025, 11:39 AMMatthias Zepper
03/25/2025, 11:39 AMutils.py and nothing more?Arthur
03/25/2025, 11:44 AMsynced_repo and repo though and I worry a bit about yet another class with overlap being in some far-flung file. Velocity is great at the hackathon but if there is much overlap/shared functionality I’d be keen if someone (read: me throwing others under bus) was able to commit to getting that refactor over the line ASAP down the line