Hej, For <#C08JHLV9QRJ|hackathon-mar-2025-workflo...
# tools
m
Hej, For #hackathon-mar-2025-workflows-to-go, we plan to break up the download command into several independent classes to separate functionally related pieces logically for easier maintenance and testing. Shoud we make a generic
utils
folder for that in
nf-core/pipelines
similar to e.g.
nf-core/pipelines/lint
or should we still keep the
downloads
to make clear that it is functionally related? Or rather call it
classes
if it is for classes to be shared among sub-tools of
nf-core pipelines
?
j
if it's only for the download command, you can create a new folder
nf-core/pipelines/download
and move all the scripts for this command there, meaning the new
utils.py
you want to create, the
download.py
and any other thing you need for this command
m
I think, there should also be a new command
nf-core pipelines container
or the like that can be used to obtain the containers needed for a pipeline. The idea is that it can be run as a standalone program, but will also be invoked by
pipelines download
, if desired.
j
ah ok!
could it be
nf-core pipelines download containers
? or
nf-core pipelines download --containers
to point that it's part of the download
m
I think we won’t get to implement the CLI parts anyway, more preparing the foundations for such a split. I am very sympathetic towards tidying up the codebase, but I think it was predominantly Seqera repetitively their clients who needed an entirely separate tool so they can obtain the containers from private registries.
j
ok I see, so the question is only about the utils file? I would still say you can put it under nf-core/pipelines/download if you think that makes sense
m
It is about a place to put 3-4 new classes into that we can use both in download and possibly the new tool. I prefer to have them in separate files instead one large
utils.py
to reduce merge conflicts and generally allow for a clearer structure. Essentially one file per class more or less, similar to the synced repo class. (Which might be removed, since I think it is essentially not used), because the subclasses use very little functionality from it.
j
sorry @Matthias Zepper I missed your message between all the notifications 😱 I vote
nf-core/pipelines/download
and inside this
download.py
containers.py
new_class.py
etc.
✅ 1
m
No worries. Yes, that is what we are doing now!
🙌🏻 1