Why do I see this at the bottom of Usman's modules...
# team-maintainers
s
Why do I see this at the bottom of Usman's modules PRs (e.g. https://github.com/nf-core/modules/pull/7825/files)
p
Is the question why the PR looks as it does or what it means?
s
What it means
p
Trailing newline added?
The red background on the text is because it's invalid JSON
p
For extra clarity; the current version of the that file doesn't end with a newline, so you get this behaviour:
Copy code
pontus@lalage:~/Utveckling/nf-core/modules$ cat modules/yaml-schema.json 
meta-schema.jsonpontus@lalage:~/Utveckling/nf-core/modules$
rather than
Copy code
pontus@lalage:~/Utveckling/nf-core/modules$ cat modules/yaml-schema.json 
meta-schema.json
pontus@lalage:~/Utveckling/nf-core/modules$
s
It looks like the same file is being added and removed, rather than just showing changes to the file
p
ahh, I didn't spot that, was focussing on the diff sorry
That is weird, don't know
Some hidden metadata?
p
I can't be bothered enough to check out the fork where it's coming from, but since it's one commit only I suspect it's rather something with github showing it in a certain way than the commit being weird (I may be wrong but think that if it was removed and readded, that couldn't happen in a single a commit).
i
This file is a symlink, GitHub behaves weirdly with these. I had to re-link this myself for one PR because it was broken and made pre-commit freak out
j
hi! as Igor says this is a symlink, and it was removed at some point (then pre-commit starts failing), it would be good to check that this doesn't happen by mistake again 🙏🏻
I just checked this particular PR and everything looks ok 👍🏻 😊