Hello <#C043UU89KKQ|team-maintainers>, <@U03UCQH8F...
# team-maintainers
j
Hello #team-maintainers, @Louis Le Nézet found out that our linting of subworkflows (particularly the ones we have in the pipeline template) was a bit broken since we have more than one workflow per subworkflow. This lead to different mistakes because all workflows were parsed as one. After some thought, we think that the best is to only allow 1 workflow/subworkflow. Any strong disagrees?
j
Go for it
Keeps in line with modules concsept too
s
Is this only applying to the pipeline template subworkflows? I think all the others only have one workflow
(I realise that is mostly what you said)
j
yes 😄 but we would also add a linting step to ensure that there isn't more than one workflow
👍 1
s
So PIPELINE_INITIALISATION and PIPELINE_COMPLETION would be split up? Anything else that this actually applies to?
j
that's all for now
here's the PR from Louis, for reference https://github.com/nf-core/tools/pull/3486/files
m
we think that the best is to only allow 1
who's we?
j
me
and j↓lia and louis
👍🏻 1
OH FFS
Jüũ↑ùûúlia
😂 2
THERE WE ARE
Júlia
m
ok, so sensible people then
I do see the appeal in having just the one subworkflow in a subworkflow
but I do like the possibility to have multiple subworkflows in just the one script
this 1
especially for such utils subworkflows
@Adam Talbot what's your take?
j
it will probably be only a warning, and we can allow skipping this linting, but I think is more clear if the standard is 1subworkflow 1workflow
🙏 1
m
ok for me with just a warning for now
and @Louis Le Nézet if you continue to do stuff like that, it's an automatic bump to #team-maintainers
j
Once your PhD is done 😉
s
Pfft, don't need to wait for a PhD to be finished
l
... but I just wanted to help a bit 🥲
m
Too late, you're in
🤣
j
I did say basically you are in for doing what you're already doing 🤷 You can still change your mind and make it official ;)
l
Now that I joined the channel... Let's go ! And if I didn't, I think that Maxime would have pestered me until I join 😆
❤️ 1
j
YESSSSSSSSSSSS
m
🚀
j
Ok, @Maxime Garcia can you do onboarding!
(with kids and in-not-actually-laws)
m
@Louis Le Nézet I need your gmail/google account for the nf-core maintainers google calendar -if you use it And you need to make a PR here - https://github.com/nf-core/website/blob/main/sites/main-site/src/content/about/governance.mdx#maintainers to add yourself to the maintainers list
l
louislenezet@gmail.com I will do the PR
🎉 1
m
He is just starting officially in #team-maintainers, and he's already sorting things alphabetically meow love cc @Rike Hanssen
😅 2
😂 2
🔠 1
shakefist 1
j
welcome to the club
a
> @Adam Talbot what's your take? even I am shocked, I don't have a strong opinion
I guess it had to happen eventually