I created a subworkflow, but didn't create a corresponding meta.yml: https://github.com/nf-core/modules/pull/7817 Still it passes linting 🤯

Yes, the

meta.yml

doesn't raise a full error if it doesn't exist at all. I believe this has been the case since their introduction

I see, nice loophole

Ok, so I just checked and I think this is actually a bug someone (😶‍🌫️) introduced when trying to make local subworkflow linting check

meta.yml

if they exist but otherwise not raise an error.

loool

Can you just confirm for me what lint command you are running and where?

I didn't actually try to lint anything, I just pushed my subworkflow without meta.yml, and no issues were reported (from linting) via GHA.

Wait, HOLD UP. I don’t think we lint subworkflows AT ALL in CI!

If I delete the

meta.yml

, and run linting locally with

nf-core subworkflows lint archive_extract

, I do indeed have the

Subworkflow meta.yml does not exist

error

Check out: https://github.com/nf-core/modules/pull/7817/checks And look at the

run linting

step. It only lists,

lint modules

which is (obviously) skipped

ok, so we would need to add linting for subworkflows

@Júlia Mir @mashehu was there some reason we aren’t currently running

subworkflows lint

in CI?

I don’t think so…

@Arthur you want to have a go then?

I wouldn’t really know where to start modifying the GitHub CI. It should probably be relatively straightforward to mimic what already exists for the

lint modules

command but not at 18.30 haha

i can have a quick look

Let's go

argh github ci shakefist I knew it was a trap

Seems to be stuck in

Waiting for pending jobs

for

nf-core lint subworkflows

i will give it one more go:

Run Linting
Error when evaluating 'strategy' for job 'nf-core-lint-subworkflows'. .github/workflows/lint.yml (Line: 151, Col: 22): Error parsing fromJson,.github/workflows/lint.yml (Line: 151, Col: 22): Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/lint.yml (Line: 151, Col: 22): Unexpected value ''

yeah, I assumed the waiting was more a symptom than a problem

The

get_module_name

part of

nf-core-changes

action seems like it wouldn’t ever work for a subworkflow?

yep, added that now. PR incomign

Let's go