Has anyone run the alignment step of Sarek recentl...
# modules
j
Has anyone run the alignment step of Sarek recently? I have a quick question about your work directory if so! Could you tell me the contents of the GATK4_APPLYBQSR folder? The output bam/cram should be there (as well as the .command files), but is the input bam/cram there too?
#️⃣ 1
p
Better to ask this in #sarek
j
I did, was just hoping to get some more eyes on the question. The question also applies to anyone running APPLYBQSR in their own pipelines.
I'm about to open an issue in the modules repo pertaining to this module, but I was hoping to find someone who has also run it to make sure that the bug I'm encountering is not something that I'm experiencing alone.
p
ah ok, fair enough 👍🏻
j
I did end up finding some other issues/conversations that reference my bug. I'm going to make a issue on the modules repo for it now.
m
Very good catch @John Orgera I'll make sure to patch this
j
@Maxime Garcia I made a PR for this issue and added you as a reviewer. It was already approved though and I'm going to merge it, but I figured you may want to know so you can update the module in Sarek 👍
m
Why all the changes in the meta.yml file?
j
It was giving me an error telling me I had to lint it so I just used nf-core lint --fix on it. Maybe there was a template change between this PR and the last one?
m
I see, we might have been out of date with the specs
We really need versions on that
👍 1
j
Thanks for the approval/merge. I tested this on my HPC system where I initially observed the issue. This fix fixed the issue. Previously the aligned bam was copied 100x times for the APPLYBQSR step so this definitely should help Sarek users with the same setup as me.
m
If you want to open the PR on the Sarek side, please go on
j
Sure
m
Do we have more modules with such output definitions?
j
Looks like this markduplicates has the same issue.
m
OK, let's be smarter than that
j
I think I can use the meta.yml to programmatically find every module that has the same file extension for input and output and also globs the output with *.{file extension}
party this 1
m
let's create an issue with a list on sarek
j
Okay, I'll find all the modules and make an issue. I do have a PR ready for APPLYBQSR though. Should I make it or hold off on it for now until we can get the other modules resolved as well?
m
No, I'm happy with fixing it one module at the time
👍 1
But just to keep track of all the issues for you
and if anyone wants to jump in on the effort
j
Okay, which branch should I make the PR to?
m
Please join #sarek_dev if you haven't done already
On the sarek side, you can do it on
dev
, and we can do it all at once, as I do assume there will probably be some other lingering issues