Hi folks - <@U07RHAG6D89> and I are poking around ...
# spatialvi
p
Hi folks - @David Lecomber and I are poking around in this pipeline trying to get linux/arm64 support running (see the #C07S9BW2STT channel). I was wondering what env/environment.yml file is used for? It struck me that it looks quite a lot like the shared
nf-core/quartonotebook
module (with its own environment file). Is it possible that the former is a historical relic and not used anywhere? Or have I just missed where it is?
e
The Conda environment file is what's used to install things inside the Docker container (which is also done in the
quartonotebook
module). The installation for the packages that are used in the pipeline is, sadly, non-trivial, so this was the solution that has worked so far. We haven't checked recently if it's possible to install using e.g. Seqera Containers, but that's something that we will check once the active development on implementing Visium HD into the pipeline is finished (as that requires additional changes to the environment).
Also, the image currently used is a multi-platform image for linux/amd64 and linux/arm64, so that part is at least already working.
p
Which parts of the pipeline use this container, and what's it called?
Is it the two local modules you're talking about?
So the read data and merge data scripts, using docker.io/erikfas/spatialvi ?
e
It's currently three separate modules (which could possibly be divided up further once the environment is finalised, but there might still be quite some overlap so one reason to keep it reused for all relevant modules):
read_data
,
merge_data
and
quartonotebook
p
gotcha, ok this was super helpful, thanks
If you get a moment, would you mind adding a bunch of comments into these files so that when I stumble across them again in six months and have inevitably forgotten this conversation, it'll be obvious to someone reading?
eg. both of the
env/
files saying that these are used to create the image xxx which is used in processes yyyy
And again in the process code, next to the container - saying where the environment and docker files are
I also wonder if it'd make sense to remove the
Dockerfile
and
environment,yml
file from the quartonotebook module if they're not being used? That threw me a bit (should be fine to do with
nf-core modules patch
I think?)
And finally,
<http://docker.io/erikfas/spatialvi|docker.io/erikfas/spatialvi>
should really be switched over to
<http://quay.io/nf-core/spatialvi|quay.io/nf-core/spatialvi>
at some point - though I understand that if it's still in heavy flux right now then it might not be convenient to do so (as it needs someone from the core team to push updates)
Again if you add a comment next to it saying that this will be pushed there in the future, that'll stop me / other people asking about it again 😅
e
Sure, I can add some comments, no worries! Yes, we can also remove the module environment with a patch, good point.
p
Thank you! 🙏🏻