Leaderboard for most open PRs in the nf-core/modul...
# team-maintainers
s
Leaderboard for most open PRs in the nf-core/modules repo: 1. @Edmund 22 2. Renovate bot 9 3. @Usman 8 4. @Maxime Garcia 6 5. Jianhong Ou 5 6. @Júlia Mir 5 7. @Famke Bäuerle 4 8. Felix Lenner 4 9. @Adam Talbot 3 10. @mashehu 3 11. @Sateesh_Peri 3 And channel members with any number of open PRs (manually filtered, so apologies if I've missed you off): 1. @Rike Hanssen 2 2. @Igor Trujnara 2 3. @James Fellows Yates 2 4. @Jonathan Manning 2 5. @Marcel Ribeiro-Dantas 2 6. @Carson Miller 1 7. @Ken Brewer 1 8. @Mahesh Binzer-Panchal 1 9. @Nicolas Vannieuwkerke 1 10. @Phil Ewels 1 11. @Simon Pearce 1
🎉 3
Can you please check your open PRs and either finish off or close any that can be closed.
j
I do'nt understand the second?
s
still in the modules channel but not necessarily the leaderboard
j
Ah top is anyone and second is maintainers only?
👍 1
m
Are you kicking off the spring cleaning before the actual kick off?
🤣 1
Are you doing a Maxime and trying to take over nf-core?
🤣 1
maxime 3
j
Ah top is anyone and second is maintainers only?
But Fämke, Sateesh, Matthias, Maxime, Jülia are all maintainers
Are you kicking off the spring cleaning before the actual kick off?
Yeah because @Simon Pearce is a badass rebel
🙌 2
party this 4
s
You can find your open PRs with a nice link like this (just replace my username with yours 😉 ): https://github.com/nf-core/modules/issues?q=is%3Apr+is%3Aopen+author%3Asppearce
👍 1
j
Schedule my module reminaing completion for wednesday salute
j
Closed!
s
But Fämke, Sateesh, Matthias, Maxime, Jülia are all maintainers
Almost all of the top are maintainers 😉
😬 1
And Jianhong's 5 I think I'm going to close all this week, but going to message first
👍 1
j
Carson is also not able to active at all atm
so dpeending how old might be worth closing
(but he might respond if you ask)
s
I think I finished that off on Friday and it just needs a review
👍 1
oh, no, that is a different module of his I finished off, I'll take a look at that other one
s
Sarek is using it
Sarek is using it
f
I think one of mine I am trying to debug for ages (mismatch of conda version md5), and one other needs to stay open because it needs another one implemented first.
a
rookie numbers
C’mon renovate bot. Sort it out.
😆 3
s
If they need to stay open that is fine, but please take a look at them 😉 Maybe post on the PR so you don't get any direct questions from me about them
👍 1
n
My one open PR is mainly waiting for some clarity in the Nextflow codebase, so I'll keep that one open a little bit longer I think 🙂
👍 1
s
C’mon renovate bot. Sort it out.
Absolutely, being considerably beaten by @Edmund I think it has a limit on the number of open PRs it can have 😉 , but I think they can be all closed until we actually have automatic container bumping
👍 1
👍🏻 1
i
One of my module PRs is based on a Python package we're writing, I will merge it once we're happy with the related part of the code to avoid having to make version bump PRs in a week. We should hopefully be done this week, but I can't promise that. The other is a problematic one because it's someone's issue I picked up a year ago at the hackathon, I don't know the tool, there seems to be no test data, and the issue author is unresponsive.
👍 1
f
@Simon Pearce Doing all the work before we even had the kickoff shakefist . Let @Mahesh Binzer-Panchal @Nicolas Vannieuwkerke and me know what you want to do so we can divide and conquer 😉
❤️ 1
r
marie kondo
💯 3
u
I closed mine. Thank you!
😮 1
s
Does that include your nf-test migrations that had ran into issues?
u
Yes! I closed them for now as conda was failing.
s
(because we'll need to finish those modules off anyway, as we are trying to finish off the migration in the hackathon)
u
I think in most cases, I had just run the automated converter which has been improved now. The real difficulty is the conda fail issue.
j
small update regarding my PR 🧹 • closed 2 PRs • finished 2 PR • keeping 1 PR open
❤️ 1
s
Sarek is using it
m
Sorry, I had a family emergency so I was away for a while. I'll get to what I can when I've cleaned up what I need to do.
m
No worries, take care
s
No worries Mahesh
r
NO worries Mahesh! Hope all is well or getting better!
💀 1