Anyone has any idea on this error? <https://github...
# tools
k
Anyone has any idea on this error? https://github.com/nf-core/variantbenchmarking/actions/runs/13721006402/job/38376305153?pr=164
Copy code
Run if [ "224" -ne "224" ]; then
/home/runner/work/_temp/82dfe4b2-2869-4c20-8a23-2e06d5e9136d.sh: line 12: syntax error: unexpected end of file
Error: Process completed with exit code 2.
m
I do not know how this ended up in there, but there is a leftover Jinja template markup in the GitHub action that crashes the script:
Copy code
fi{% endraw %}
PS: But
[ "224" -ne "224" ]
, so the number of images stays constant and the download works! 🎉party parrot
I see also one more
{% endif %}
😱
k
well, I have been suggested to copy over the solution https://github.com/nf-core/tools/pull/3399 here. So I might messed things up 🫣
m
good gatch @Matthias Zepper
keanu thanks 1
🎉 1
m
Yes, that explains it. Those markup tags are removed by #tools when running
nf-core pipelines create
and allow customizing the template, but of course not when manually copying parts of the template. And yes, that is not and doesn’t have to be common knowledge. I first noticed them when debugging the test about a year ago and initially blamed Copilot 🤖 for introducing them, because I coincidentally had activated it in VSCode for the first time when those strange notations appeared unexpectedly in my PR. In reality, mashehu had just pushed them quickly before merging after approving my PR. 😄
k
so I just need to remove this line:
fi{% endraw %}
many thanks! You must have very sharp eyes 😄 👀
m
No, you still need the
fi
. Just everything that looks like
{% some word in here %}
k
okay will give it a try 😄 I hope i WONT BREAK MORE THINGS 🤣
penguin construction 1
🤣 1
m
You must have very sharp eyes 😄 👀
Rather experience…
🤣 2
k
m
Copy code
gh workflow run -R "nf-core/variantbenchmarking" --ref "fix_pipeline_download" --field "testbranch=dev" "download_pipeline.yml"
You can always test an action also, if you use the GitHub CLI.
-R
is the repo and
--ref
the branch from which you want to launch that action, in this case
download_pipeline.yml
. The
--field
is an input parameter and only relevant, if said action takes any.
❤️ 1
k
wouv that you! that seems very helpful
m
Yes, it is. I have kicked a test run with the modifications off, but you are merging faster than a blink of an eye 🙂 (which in this case is perfectly fine, since I am 99,9999% sure that the changes make the run pass)
k
🤣 I am not patient enough 😅 and hungry
but yes it works!! thank you so much
m
So no weekend or dinner before release? Wow, you are tough on yourself! silentdiscreteapprovingnod
k
celebrations are for weak people 🤣 - just joking -
m
Not really…after all Heidelberg local site has planking sessions for the Hackathon 🪖 🙈 Ups…should not have told, now everyone will cancel their participation 📉🇩🇪😬
🤣 1
k
almost being forgotten! I need to add plank sessions !!
m
@Matthias Zepper what have you done?
m
I can see no harm here…😉
🏋️‍♂️ 1
🤣 1
m
fair enough