<@UQZG2UCF3> Why does the AWS Megatest Action trig...
# team-maintainers
f
@mashehu Why does the AWS Megatest Action trigger when there is one approval but then immediately fails because it checks for 2 approvals? I am guessing didn't have a way to do the 2 checks inside the workflow? https://github.com/nf-core/molkart/actions/runs/13661142156/job/38192334145?pr=105
Sorry for asking this here but didn't know what other channel makes sense for this: #ci-runners?
m
Exactly, there is no trigger threshold for number of reviews, just review or not and then I can check for how many. But I am not happy with this ci workflow in general and trying to think about better ways to achieve what we want (aws tests just before a release, so we know that they work, but don't trigger them too often)
👍 1
f
Ok, I can understand that. It's just a really strange experience to get an approval and immediately see a big red x pop up 😄. It's been a while so forgot about that
@mashehu Somehow even after 2 approvals it didn't trigger though? https://github.com/nf-core/molkart/pull/105
f
That's not the AWS megatest though?
m
ah, sorry, too many things at once
f
All good
CleanShot 2025-03-06 at 09.21.30.png
Just wondering why it didn't trigger
m
shakefist 1