Louis Le Nézet
02/26/2025, 2:01 PMcompletionEmail , completionSummary , ... not used in main.nf (for utils_nfcore_phaseimpute_pipeline) but they are used in the PIPELINE_COMPLETION workflow. Does tools checks only for the first workflow present ?
• Included component UTILS_NEXTFLOW_PIPELINE, UTILS_NFCORE_PIPELINE and `UTILS_NFSCHEMA_PLUGIN`versions are not added in main.nf but they don't emit any. Should they be change to a function therefore ?
• I have a few: Subworkflow includes less than two modules. But these subworkflow does heavy channel reconfiguration / merging. Should I set the channel modification as a function ? and where should I put these functions ?Arthur
02/26/2025, 2:22 PMLouis Le Nézet
02/26/2025, 2:36 PMArthur
02/26/2025, 2:53 PMpipelines lint runs the module/subwf linting 🤔Louis Le Nézet
02/26/2025, 2:59 PMpipelines lint does lint the modules and subwf, isn't it something wanted ?Arthur
02/26/2025, 3:05 PM.nf-core.ymlLouis Le Nézet
02/26/2025, 3:09 PMArthur
02/26/2025, 3:15 PMlint section in their .nf-core.yml
That means that their code defaults to not running linting on components when using nf-core pipelines lint per this line.
But since phaseimpute has no lint section at all it falls into the else and it runs them.
@mashehu you are the git blame for this code, was it intended that the default behaviour differed between people with and without a lint section, or is this actually a bit of a bug.
The way I see it there are 2 potential issues here:
• incorrect default behaviour of the pipelines lint command regarding components
• bad subworkflows lint checks which aren’t working as expected for some casesLouis Le Nézet
02/26/2025, 3:16 PMLouis Le Nézet
02/26/2025, 3:37 PMlint:
files_exist:
- conf/modules.config
And all the modules/subworkflow linting dissapear...
From my point of view I would prefer to have the whole linting when running the pipeline instead of having to individually lint pipeline/module/subwf 🤔Louis Le Nézet
02/26/2025, 5:35 PM_ in it's name. nf-core thinks it should be a folder.
(e.g. I have a local module named add_columns and the linting give me Included module/subworkflow add/columns missing in meta.yml )
As we shouldn't use CamelCase for the modules names how can we solve this ?
I have local modules such as bam_chr_extract than would be difficult to name without separation...Arthur
02/26/2025, 11:54 PMLouis Le Nézet
02/27/2025, 11:06 AMLouis Le Nézet
03/03/2025, 3:00 PMcompletionEmail , completionSummary and others needs to be just above the workflow where they are used and the warning disappear. This might need to be moved in the TEMPLATE.