Had a bigger discussion question come up. Any opin...
# team-maintainers
e
Had a bigger discussion question come up. Any opinions? https://github.com/nf-core/sarek/pull/1761#issuecomment-2679920045
j
I like having everything in the changelog, can be added to a different section for developers for example. It's useful when something breaks to go and see everything that changed
💯 1
m
Agreeing with @Júlia Mir
But I see the point
And I think having a dedicated section makes sense
s
I think I'm with Edmund here, don't need CHANGELOG entries for non-functional changes personally (including "back to dev")
m
As a dev, I do want an entry for everything, it's a #hill-to-die-on and non-negociatble
➕ 1
but a separate section for end user makes a better sense
e
As a dev, I do want an entry for everything
That's what the git log is for shakefist
m
ok, so I should look at
git log
, this is what you're telling me
🤔
e
Yeah and people devs should write better commit messages.
The pipelines are for users, not devs. They don't care about GitHub actions or what CI is. They don't know how to use
git log
. They care if the pipeline switched from nf-validation to nf-schema though, because that might break something for them.
m
Yeah and people devs should write better commit messages.
Touché
🤺 1
Bactopia is a good example
I like that
j
sorry I still think important changes should be there, even if they are for devs. Agree with fixing typos though
writing better commit messages sounds good in practice but very difficult in a big community where we have lots of contributors and some of them are not experienced
(and even experienced ones forget about good commit messages 🤫 )
party this 3
e
Maybe just better PR titles?
Idk I'm not opposed to having two changelog things, I just want to make it clear to users. Maybe just clean up the release notes on the GitHub releases?