Hi, not sure this is the right channel. I've this ...
# pipeline-maintainers
t
Hi, not sure this is the right channel. I've this error:
Test successful pipeline download with 'nf-core download' / download (pull_request_target)
. See the attachment below. Can you help un derstand where is the issue? This is the PR: https://github.com/nf-core/fastqrepair/pull/2
m
is this with the most recent template (3.1.2)?
t
just merged
this error after the actual merge
before the merge, I had two similar errors like this one
m
can you change
pull_request_target
to
pull_request
?
t
yes, where?
t
ok yes, will do
I've tried this:
pull_request:
types:
- opened
- edited
- synchronize
branches:
- main
- master
pull_request:
branches:
- main
- master
but, I obviously get this error
SyntaxError: Map keys must be unique; "pull_request" is repeated (8:3)
and without
pull_request_target:
branches:
- main
- master
but I always have an error
m
Cc @Matthias Zepper
m
I do not know what the problem is, but there is also no point in overthinking this. The
pull_request_target
trigger tests the pipeline on master, whether there is a regression towards the new
dev
version (a superfluous behaviour we are anyway going to change soon). But since you are about to release your pipeline for the first time, there is no previously working version of it to test against. What matters is, that the test succeeds on the
dev
branch, so the failure can be safely ignored. If you wish, you can edit the CI test manually as shown here to avoid having a failing test in the PR.
t
Ok thanks. I'll notify reviewers at the release time about this.