Hi, I am getting kind of confused by `nf-core` . T...
# tools
n
Hi, I am getting kind of confused by
nf-core
. There is maybe (probably) a or several misconfigurations in my pipeline. For example I get this during linting:
Copy code
.github/workflows/awsfulltest.yml is not triggered correctly
How can I set those triggered to be correct?
Another thing that happens is:
Copy code
files_exist: File not found: conf/igenomes.config                                                                                                                                                                                                           
files_exist: File not found: conf/igenomes_ignored.config                                                                                                                                                                                               
files_exist: File not found: ro-crate-metadata.json
There is little use for igenomes in my case so I deleted those files, are they strictly required? I have 0 clue what the ro-crate-metadata.json should contain
m
you can ignore different linting tests in the
.nf-core.yml
file, e.g. https://nf-co.re/docs/nf-core-tools/api_reference/latest/pipeline_lint_tests/files_unchanged
this 1
👍 1
j
The awsfulltest.yml must have this in the
on:
section
Copy code
on:
  pull_request:
    branches:
      - main
      - master
  workflow_dispatch:
  pull_request_review:
    types: [submitted]
could it be that you are using an old version of the nf-core template?
n
Ok thanks Júlia, that fixed the issue.
I am not sure about which version of the template I am using to be honest, how can I check?
I am not sure if that is a browser issue, but for file_exist the thing that is supposed to be in the >Note is placed below it https://nf-co.re/docs/nf-core-tools/api_reference/3.1.1/pipeline_lint_tests/files_exist
j
do you have a link to your pipeline?
n
I would like to merge into dev and then do the release, so I am trying to get things into a passing state
j
you are using 3.1.1, the most recent one 👍🏻 you can see it here
n
That link does not take me anywhere useful, maybe the page is too large.. is it
nf_core_version: 3.1.1
in .nf-core.yml?
👍🏻 1
j
oh sorry, yes, the
.nf-core.yml
n
Cool, thanks. I have one more question that is related to the tests. I only noticed today that it is possible to run multiple tests. Is that something that I should do? I think it makes sense, but it essentially means the tests run 5x as long since I test 5 different profiles. The overall time is 12-13 minutes
by tests I mean CI tests
j
you can update your github action to use a matrix with the different test profiles you want to use, for example https://github.com/nf-core/crisprseq/blob/master/.github/workflows/ci.yml#L36-L42
this is then used here
and these tests will run in parallel
👍 1
n
Hm, I see that is probably better than just having 5 tests after
run:
Thats pretty cool, thanks