Do we want to allow integer sample names? Seems li...
# rnaseq_dev
j
Do we want to allow integer sample names? Seems like something that could cause trouble, though I'm not completely opposed
m
like a sample name being
12342
only?
j
indeed
m
yeah, I don't see any issue with that
j
Sorry, forgot to post the PR the prompted this question: https://github.com/nf-core/rnaseq/pull/1421
m
yeah, for me an integer is a string
so I see no issue there
maybe more a #C056RQB10LU question
@Nicolas Vannieuwkerke what is your take on this?
n
Should be fine in 99% of the cases. You can still add do a
.toString()
at the start of the pipeline in
meta.id
to be 100% safe
It just might do some weird stuff where
+
is used to concatenate strings together instead of interpolation
this 2