Does anyone know why on our dev to master PR here:...
# tools
j
Does anyone know why on our dev to master PR here: https://github.com/nf-core/taxprofiler/pull/563/files we having double the number of tests... every CI test has one for 'pull request' and another for 'push'...
j
pull_request
triggers the test when a pull request is opened, while
push
triggers them when you push to the branch
dev
j
I don't think the former is working correctly then
🤔 1
It's happening on any chance on the PR, not just on opening
j
ah I was wrong, reading the docs I see modifications on the head branch of the PR also trigger the
pull_request
event, so pushes to
dev
trigger that
in other PRs, you push to your fork branch, not
dev
, so that's why you only see the tests once (on
pull_request
), but on PRs from
dev
to
master
you see both
j
Is there not a way to stop on
dev
>
msater
running both?
j
we could remove the
push
trigger, but that's useful to run the tests when we merge other PRs to
dev
j
Yes exactlyu
It's more the PR one I think that is the issue
j
the
pull_request
one is also useful to run the tests if you push tot he fork branch on PR fork>dev
I don't think there's a way to have an "or" for these two
j
Hrm
Because basically at the moment, based on our matricx set up
We have 2 nextflow versions x 3 profiles x N number of tests
e.g. for taxprofiler we have like 11 tests
so that's already 66 tests
And then if we have both pull requests and pushs, that's 132 tests being executed
😅
A lot of sad polarbears 😞
j
too many
let's open an issue and think of a way to fine grain this 😄
❤️ 1
j
Tools or ops?
j
🤔 I think tools
m
I think, one could restrict the
on: pull request
/
pull_request_target
trigger further?
Copy code
pull_request:
    types:
      - opened
      - edited
      - synchronize
      - ready_for_review
      - review_requested
      - [...]
Rereading the docs makes me realise that the Download action is also excessively triggered..
At least for the Download action, I am now doing a bit of spring cleaning 🧹🧼…I can include some more stuff to that PR if somebody instructs me accordingly: https://github.com/nf-core/tools/pull/3399
j
Sorry making the issue now for my request, had early lunc hthen random meetings