How do I work around this issue? Tried messing aro...
# tools
a
How do I work around this issue? Tried messing around with every version of
manifest.authors
and
manifest.contributors
but nothing seems to fix it:
Copy code
INFO     Making a new template pipeline using pipeline variables                                                                                            sync.py:261
DEBUG    Got '/Users/adam.talbot/nf-dragen' as path                                                                                                        utils.py:280
DEBUG    No config cache found                                                                                                                             utils.py:321
DEBUG    Running command: nextflow config -flat /Users/adam.talbot/nf-dragen                                                                               utils.py:364
DEBUG    Could not open /Users/adam.talbot/nf-dragen/main.nf to look for parameter declarations - [Errno 2] No such file or directory:                     utils.py:346
         '/Users/adam.talbot/nf-dragen/main.nf'                                                                                                                        
DEBUG    Popen(['git', 'reset', '--hard'], cwd=/Users/adam.talbot/nf-dragen, stdin=None, shell=False, universal_newlines=False)                             cmd.py:1253
ERROR    Failed to rebuild pipeline from template with error:                                                                                 commands_pipelines.py:334
         'manifest.author'
j
do you have both author and contributors in the manifest fields?
a
nope:
Copy code
manifest {
    name            = 'seqeralabs/nf-dragen'
    author          = """Harshil Patel, Graham Wright"""
    homePage        = 'https://github.com/seqeralabs/nf-dragen'
    description     = """Nextflow pipeline to run Illumina DRAGEN software"""
    mainScript      = 'main.nf'
    nextflowVersion = '!>=23.04.0'
    version         = '1.0dev'
    doi             = ''
}
And if I delete them I get the same problem
j
with only manifest.author should work, but can you try having both just in case?
a
same problem
Copy code
manifest {
    name            = 'seqeralabs/nf-dragen'
    author          = """Harshil Patel, Graham Wright"""
        contributors    = [
        [
            name: 'Harshil Patel',
            affiliation: 'Seqera',
            email: 'harshil.patel@seqera.io',
            github: '@drpatelh',
            contribution: ['author'] // List of contribution types ('author', 'maintainer' or 'contributor')
        ],
        [
            name: 'Graham Wright',
            affiliation: 'Seqera',
            email: 'graham.wright@seqera.io',
            contribution: ['author']
        ],
    ]
    homePage        = 'https://github.com/seqeralabs/nf-dragen'
    description     = """Nextflow pipeline to run Illumina DRAGEN software"""
    mainScript      = 'main.nf'
    nextflowVersion = '!>=23.04.0'
    version         = '1.0dev'
    doi             = ''
}
🤔 1
Should I commit to the TEMPLATE branch?
nope, no change
j
and does it work as expected if you run
nextflow config -flat
?
a
yep
Copy code
> nextflow config -flat | grep manifest
manifest.name = 'seqeralabs/nf-dragen'
manifest.author = 'Harshil Patel, Graham Wright'
manifest.contributors = [[name:'Harshil Patel', affiliation:'Seqera', email:'harshil.patel@seqera.io', github:'@drpatelh', contribution:['author']], [name:'Graham Wright', affiliation:'Seqera', email:'graham.wright@seqera.io', contribution:['author']]]
manifest.homePage = 'https://github.com/seqeralabs/nf-dragen'
manifest.description = 'Nextflow pipeline to run Illumina DRAGEN software'
manifest.mainScript = 'main.nf'
manifest.nextflowVersion = '!>=23.04.0'
manifest.version = '1.0dev'
manifest.doi = ''
j
weird.. is the pipeline public? can I have a look?
a
I'm happy to nuke it and start again if that's what it takes 😆
But I've been doing the following: • checkout a new branch
template_update
• Modify the
.nf-core.yml
• Run nf-core pipelines template sync with v3.1.1
In fact, if I
rm *
and make a
main.nf
and
nextflow.config
, I get the same problem:
Copy code
KeyError: 'manifest.author'
(and add the
.nf-core.yml
back)
Here is my new
nextflow.config
, I get the same error:
Copy code
manifest.name = "dragen"
manifest.description = "Nextflow pipeline to run Illumina DRAGEN software"
manifest.author = "no one"
manifest.version = '1.0dev'
Do we need to catch this exception? Can we just raise the appropriate error?
This should be
elif "manifest.author" in wf_config:
j
I am trying with the dev version of tools and I don't see an error
you were running
nf-core pipelines sync
right?
a
Correct,
dev
version
sorry, v3.1.1
j
could you try with dev? maybe it is already fixed there?
ah, is it fixed with your PR? I understood they were different issues
a
I'm gonna try on dev, I assumed it was pretty similar to 3.1.1
yep, with
dev
I get the same error
After my fix it seems correct:
Copy code
manifest {
    name            = 'seqeralabs/dragen'
    author          = """Adam Talbot, Harshil Patel, Graham Wright""" // The author field is deprecated from Nextflow version 24.10.0, use contributors instead
    contributors    = [
        // TODO nf-core: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
        [
            name: 'Adam Talbot',
            affiliation: '',
            email: '',
            github: '',
            contribution: [], // List of contribution types ('author', 'maintainer' or 'contributor')
            orcid: ''
        ],
        [
            name: ' Harshil Patel',
            affiliation: '',
            email: '',
            github: '',
            contribution: [], // List of contribution types ('author', 'maintainer' or 'contributor')
            orcid: ''
        ],
        [
            name: ' Graham Wright',
            affiliation: '',
            email: '',
            github: '',
            contribution: [], // List of contribution types ('author', 'maintainer' or 'contributor')
            orcid: ''
        ],
    ]
    homePage        = 'https://github.com/seqeralabs/dragen'
    description     = """nf-dragen is a simple, proof-of-concept Nextflow pipeline to run the Illumina DRAGEN licensed suite of tools."""
    mainScript      = 'main.nf'
    defaultBranch   = 'master'
    nextflowVersion = '!>=24.04.2'
    version         = '1.0.0dev'
    doi             = ''
}
j
ok thanks for the fix 🙂 I made a comment there as I think we should skip catching the exception, but otherwise I think it's good
there is also another error related to manifest.author which I will try to fix now, but I think it's not related to yours https://github.com/nf-core/tools/issues/3373