Hey! I opened the initial pseudo PR for the nf-cor...
# pipeline-maintainers
e
Hey! I opened the initial pseudo PR for the nf-core/proteinfamilies pipeline (dev branch against TEMPLATE). Most of the modules are being reused in the pipeline for different purposes. I understand this can be confusing if you are playing with protein families for the first time, so feel free to poke me for questions any time. Looking forward to your reviews and comments. https://github.com/nf-core/proteinfamilies/pull/17
e
e
Woaa, that's..huuge xD Never used it before, but I'll install and run locally with tests to get familiar with it. I am not sure I'll be able to do a thorough review any time soon though because of conference/vacation abroad for the next two weeks. I'll leave my comments where I can though!
šŸ˜† 1
A metro map would be awesome šŸ˜›
j
You don't have to go super detailed
And this way you alreayd get a core review that isn't me šŸ˜ (but still happy to do so in a couple of weeks if you still ned at that point)
e
Alright! Question. Do we need nf-tests for local modules? :X And is the test.config/test_full.config enough for whole pipeline testing? Or do we need to explicitly create a whole-pipeline nf-test as well?
j
It's recommended, but not required
And it's recommended but not required šŸ˜‰
🤣 1
o
I’m interested in shadowing this pipeline review to learn about #proteinfamilies and current standards for pipelines!
j
Feel free to just do a review and if there are any doubts you can shout :)
e
And then we focus on proteinannotator, which is the logical next step of analysis for the generated family representative sequences ;)
party parrot 1