is it okay if I disable this setting, not really f...
# pipeline-maintainers
m
is it okay if I disable this setting, not really fitting for the nf-core workflow imo
🙏 2
👍🏻 2
s
isn't it a good safeguard ?
just so that no one sneaks in a unreviewed commit after approval
ya it will mean that you have to get another approval again though
m
I think we trust our members at the moment to not do this, plus increases the review workload
m
yes please
It's annoying to get someone to re-review
s
agree....lets turn it off
m
okay, turning it off for now. please keep you malicious commits to your self 😉
drevil 6
r
🤷‍♀️ yes annoying but also so often we have bad code in modules
m
but I think the annoying part is a bigger hurdle, we have already problems getting people to review a module, giving repeated reviews on the same PR or asking for more reviews will not increase the quality of the reviews.
👍🏻 1
e
I think we trust our members at the moment to not do this, plus increases the review workload
We're not very exclusive with who's a member is the issue. On the malicious commits, I don't know what those would be. I'm more concerned with the bad code in modules/pipelines from people just making "one more change" and not getting a second look. But I completely agree with the review workload so 🫠
m
not merging with failing test should prevent most of the “one more change” cases, no?
e
Not if they delete the tests, change another module, or swap the container. We can roll it back, we just might not catch them. The tests are just tools for the reviewers and developers. They're not keeping anyone from pushing malicious or broken code; the reviewers are.
m
how do we motivate people to review more then?
e
🤑
🤣 2
jk. I think we make it easier for them to review with confidence
So the tests help, they don't have to clone it locally and run anything for example.