Hey, I encountered an problem in the "Test success...
# tools
f
Hey, I encountered an problem in the "Test successful pipeline download with 'nf-core pipelines download'" github CI action defined in
.github/workflows/download_pipeline.yml
for the newest template version (3.1.1). The new version separates this action into two jobs,
configure
and
download
, which brakes the action in our case (https://github.com/nf-core/rangeland/actions/runs/12597751023). Note that we use the exact same definition of the action as the newest template does. It seems that the execution environment of both jobs are separated so that the
download
job does not find the
nf-core
executable which was successfully installed in
configure
. I've looked at a bunch of other pipelines, all of which still run a prior version of the CI action. This does not look like pipeline-specific problem to me, has anybody had successful runs of that CI action?
😩 1
p
I think that this was indeed recently updated. Hopefully @Júlia Mir or @mashehu can take a look when they're back
l
@Sofia Stamouli ☝️
m
Sorry, it seems that this is an unintended side effect of my decision to split the action into two separate jobs for security reasons. I am baffled, because I have tested that new action manually by creating a new test pipeline and pushing it to GitHub, but …well, that test was evidently not comprehensive enough. I am looking into it, respectively need to think about how to solve that issue. Because by undoing the job split, I would be reintroducing the security vulnerability that was patched.
👍 1
p
Yeah I think that @Júlia Mir also tested it with the test pipeline, plus the CI tests are there to check it too. So it managed to find its way through quite a battery of testing 😅
l
@Maxime Garcia ☝️
m
I think, I have a fix for that problem, but further tests would be highly appreciated. So please try it out and review the (draft) PR.