<@U033UF99TV1> I couldn't get to your PR in the en...
# createtaxdbj
James Fellows Yates
12/12/2024, 4:50 PM@Alexander Ramos Díaz I couldn't get to your PR in the end due to a bug fix in taxprofiler, but I might try and catch up tomorrow depending on my schedule 🙂
👍🏼 1
a
Alexander Ramos Díaz
12/13/2024, 4:55 PMIt seems that the nf-core template was updated recently, not sure if we should made the changes related to that update within the same PR or create a new PR instead. I guess it would be easier to create a new PR then merge the changes.
Alexander Ramos Díaz
12/13/2024, 4:56 PMAnyway, let me your opinion on this and I will keep working on it.
j
James Fellows Yates
12/13/2024, 4:56 PMThe template merge from yesterday is very small and shouldn't change any code level stuff
👍🏼 1
James Fellows Yates
12/13/2024, 4:57 PMBrb
James Fellows Yates
12/13/2024, 4:58 PMSo you cam continue as normal
a
Alexander Ramos Díaz
12/13/2024, 4:58 PMOk.
j
James Fellows Yates
12/13/2024, 4:58 PMIf you get weird failures you may need to add the include modules config dt the bottom of nextflow.xonfig
✔️ 1
James Fellows Yates
12/13/2024, 5:00 PMBut it should be still there for us for now so should be ok, just might get linting failures but we can ignore yhat
a
Alexander Ramos Díaz
12/16/2024, 6:11 PMnf-core-bot automatically creates a PR for the template upgrade, I thought that it would be easy, but it is not. All tests failed. I am trying to figure out what is causing the error. I added you as a reviewer, but since the holidays are approaching we could check it next year 😊
j
James Fellows Yates
12/16/2024, 6:12 PMAha, ok! No worries I'll look this week :)
✔️ 1
James Fellows Yates
12/19/2024, 10:44 AMFinally looking at it!
👍🏼 1
James Fellows Yates
12/19/2024, 10:44 AMFixing someting around the MALT missing parameter error
James Fellows Yates
12/19/2024, 10:54 AMooooh that might be problematic 😅 have to wrap the parameters in double quotes