Note that we pin `v2` of the `setup-nextflow` acti...
# pipeline-maintainers
p
Note that we pin
v2
of the
setup-nextflow
action basically everywhere. So if we make the Java installation a minor release and update the
v2
tag then no pipeline changes are needed for the fix to apply. This shouldn't be a minor release, but I'd argue it's worth it to minimise pain here. Feel free to argue in the ๐Ÿงต
m
I think adding java 21 to setup-nextflow is not a minor change and deserves a v3
I agree it's pain minimising, but it's us being lax
we're testing on edge to catch that
p
I think that the point of major versions is to avoid accidentally breaking stuff. Here it would have the opposite effect.
I agree that the timing is bad with the recent semver discussions in #team-maintainers though
However, I generally dislike semver and prefer to be practical in such cases, which won't be a surprise to most ๐Ÿ˜…
m
for me the results should be reproducible, it was failing with the latest edge, it should still fail with the latest edge
p
If it were Nextflow, I'd agree
But this is more like changing the runner instance type, as we did from GitHub Actions -> AWS on several occasions
We didn't force people to update their pipelines then (which we could have done)
m
if we were to have change the default image, I would have say it's the same, but here we change the action
i agree the end results is the same
and I agree it minimalise pin
But I don't think we should do it
that being said if you want to do it, it's an ok for me
s
I would vote minor
j
Why is not a minor release @Phil Ewels? It's not breaking anything is it? Just because nextflow has to call things differently internally, they way we interact with nextflow is no different I vote minor too
c
Minimize pain: +1 minor
p
May be a moot point, looks like the CI runs are hanging in some kind of infinite loop? confused dog
e
This is a minor IMO. We didn't have the java version locked down. Shoot, this is a patch really https://semver.org/ End users won't know the difference, it's not something they could even set.
๐Ÿ‘ 1
Nvm I see you added a java version, minor.
p
Ok when I wrote this I thought that I was pretty much done with fixing the action, but it was a trick! I've now rabbit-holed on it for most of the day and seem further away from solving it than ever ๐Ÿซ  If anyone else fancies taking the baton from me and trying to get it to work, that'd be much appreciated
My initial PR went into an infinite loop calling itself. I tried some stuff but it didn't work.
I just tried a different approach where I've moved the previous action into a subdirectory. But I'm guessing a lot here..
This based mostly on this SO post stackoverflow
oh crap, hang on - that actually worked!
โค๏ธ 4
z
I agree with @James Fellows Yates. Nothing about the use of the action or features are changing from a user perspective and that sounds like a patch release to me.
p
oh crap, hang on - that actually worked!
False alarm..
shakefist 3
This minor tweak change turned into the biggest #down-the-rabbit-hole ever..
Nearly figured it out now I think. End of the day for me but left a todo here if anyone fancies taking it on in their timezone.. ๐Ÿ‘€ ๐Ÿ˜ฌ
ok this turned into an epic battle and still not won, but hopefully inching closer. I'm also now hating this so much that I'm regretting my life choices from this morning. My suggestion is now to treat this as a short term fix and release a v3 where we tell users to install Java themselves in a template update. See this comment.
t
Ok, I got a v2.1 pushed that installs Java before installing Nextflow. I'm open to thoughts on how to long-term maintain the action to prevent this in the future. A part of me thinks maybe we should minimize the logic within GitHub actions for CI and simply call something like [Earthly](https://earthly.dev) for unit testing...I'd love to hear why I'm wrong for even thinking that way ๐Ÿ˜ˆ
โค๏ธ 1
e
Awesome!
Earthly looks pretty cool. I had my eye on dagger but it always seemed way too complicated but that looks like it might be simple enough to be dangerous