I am wondering whether its intended that `Test suc...
# pipeline-maintainers
d
I am wondering whether its intended that
Test successful pipeline download with 'nf-core pipelines download'
is running apparently everytime someone edits a comment or someone comments. This seems a little excessive. If its not intended, how to make that stop? Evidence in https://github.com/nf-core/ampliseq/actions Edit: (I seem to edit a little too often...) 😱
m
that’s a limitation by github actions. if you have a better trigger event than
edited
that still triggers when people push possible fixes, I am all ears 🙂 (one option is probably to kill concurrent runs)
d
Alright, thanks, unfortunately I am not familiar enough with github actions to have a good idea. So I keep it as is and restrict my useless editing 😄
m
🤔 Upon rereading the GitHub docs, it seems that the logic is as follows: 1.
opened
: Triggered when a pull request is opened. 2.
edited
: Triggered when the title or body of a pull request is edited. 3.
synchronize
: Triggered when new commits are pushed to the pull request. So probably we should just remove the
edited
trigger. I was mislead by the name, I guess. Since there is a separate hook for pull_reqest_comments, I do not think that adding a new comment triggers the workflow… Instead, we could also use those to be more specific: 1.
review_requested
: Triggered when a review is requested. 2.
ready_for_review
: Triggered when a pull request is marked as ready for review.
m
Isn't that trigger
on: push
?
m
Works as well, but then every push triggers the run, that would be even worse (unless restricted to certain branches like
dev
). I think, that just triggering it in pull requests to master/main is pretty good, as it will allow testing the pipeline shortly before release.