Daniel Straub
11/14/2024, 10:35 AMTest successful pipeline download with 'nf-core pipelines download' is running apparently everytime someone edits a comment or someone comments. This seems a little excessive. If its not intended, how to make that stop? Evidence in https://github.com/nf-core/ampliseq/actions
Edit: (I seem to edit a little too often...) 😱mashehu
11/14/2024, 10:41 AMedited that still triggers when people push possible fixes, I am all ears 🙂 (one option is probably to kill concurrent runs)Daniel Straub
11/14/2024, 10:44 AMMatthias Zepper
11/14/2024, 3:04 PMopened: Triggered when a pull request is opened.
2. edited: Triggered when the title or body of a pull request is edited.
3. synchronize: Triggered when new commits are pushed to the pull request.
So probably we should just remove the edited trigger. I was mislead by the name, I guess. Since there is a separate hook for pull_reqest_comments, I do not think that adding a new comment triggers the workflow…
Instead, we could also use those to be more specific:
1. review_requested: Triggered when a review is requested.
2. ready_for_review: Triggered when a pull request is marked as ready for review.moritz
11/14/2024, 8:51 PMon: push?Matthias Zepper
11/14/2024, 10:56 PMdev). I think, that just triggering it in pull requests to master/main is pretty good, as it will allow testing the pipeline shortly before release.