Hi there, I’m unable to resolve some failing linti...
# linting
j
Hi there, I’m unable to resolve some failing linting tests with the new template: What I used to have in my `.nf-core.yml`file for skipping certain tests:
Copy code
...
  nextflow_config:
    - config_defaults:
        - params.multiqc_comment_headers
        - params.custom_table_headers
Which now results in a invalid config file.
CRITICAL Config file '.nf-core.yml' is invalid
If I change it to :
Copy code
...
  nextflow_config:
    - params.multiqc_comment_headers
    - params.custom_table_headers
the
.nf-core.yml
can be read but I think those params are being skipped.
Copy code
nextflow_config: Config default value incorrect: params.multiqc_comment_headers is set as ${projectDir}/assets/mqc_comment in nextflow_schema.json but is /workspace/viralgenie/assets/mqc_comment in nextflow.config.
nextflow_config: Config default value incorrect: params.custom_table_headers is set as ${projectDir}/assets/custom_table_headers.yml in nextflow_schema.json but is /workspace/viralgenie/assets/custom_table_headers.yml in nextflow.config.
The docs (bottom of page) still mention that the first is valid syntax so are they just outdated?
m
can you please post the complete
.nf-core.yml
here?
m
and the one with
- config_defaults:
?
m
okay, the problem is we assumed lint.nextflow_config to either be a list of strings or a list of dictionaries, not a mixture of both... does this work?
Copy code
nextflow_config:
    - manifest:
        - name
        - homePage
    - config_defaults:
        - params.annotation_db
        - params.multiqc_comment_headers
        - params.custom_table_headers
j
Thx! I’ll check in a bit and keep you posted
It’s able to parse the .nf-core.yml but now the
manifest.name
and the
manifest.home
get ignored.
Copy code
nextflow_config: Config manifest.name did not begin with nf-core/: Joon-Klaps/viralgenie                                                                                           
nextflow_config: Config variable manifest.homePage did not begin with <https://github.com/nf-core/>: <https://github.com/Joon-Klaps/viralgenie>
I’ll force install your branch and test again 😄
The branch from ur PR fixes my issue.
🎉 1
m
thanks for testing