If you want, I can try to take care of the unicycl...
# bacass
f
If you want, I can try to take care of the unicycler issue, since I can also make sure that it works with Fusion, which is where I have encountered most of the issues with unicycler recently.
d
Hi @Florian Wuennemann. That would be great. If you could take care of the issue I would be happy to review it.
šŸ‘ 1
f
I'll ping you this week once I had a chance to test it out and have a PR open!
party parrot 1
@Daniel_VM Just working on this now. Two quick questions: • Can the params in
test.config
for
unicycler
be removed:
--no_correct --no_pilon
. Some of these options don't seem to exist anymore. Testing seems to pass without them! • Is it normal, that unicycler is extremely slow even for the
test
profile?
We might wanna update the MultiQC container versions as well. The current ones are quite old and don't work in Gitpod at the moment (due to some changes made in the docker or gitpod backend a while back that conflicted with the MultiQC container I believe).
d
Can the params in
test.config
for
unicycler
be removed:
--no_correct --no_pilon
. Some of these options don't seem to exist anymore. Testing seems to pass without them!
Sure ;)
Is it normal, that unicycler is extremely slow even for the
test
profile?
strange, Git CI test run
-profile test
in 6 min.
We might wanna update the MultiQC container versions as well. The current ones are quite old and don't work in Gitpod at the moment (due to some changes made in the docker or gitpod backend a while back that conflicted with the MultiQC container I believe).
The MultiQC module in nf-core/bacass has been customized to generate reports with custom tables, using data from both supported and non-supported MultiQC modules. I recently attempted an update, but the custom scripts no longer function correctly with the new versions of MultiQC. Here is the issue: https://github.com/nf-core/bacass/issues/142
šŸ‘ 1
f
@Daniel_VM PR for unicycler update: https://github.com/nf-core/bacass/pull/150. I still have to test with FUSION and will ping you here for review once that is done and confirmed 😊.
merged 1
āœ… 1
Thanks @Daniel_VM! Just merged the PR 😊
d
awesome, thankss!!!