https://nf-co.re logo
Join Slack
Powered by
Hey just wanted to check the latest on licensing r...
# linting
c
Hey just wanted to check the latest on licensing rules - my module was flagged in linting for having a GPLv3 license - does all software in nf-core need to have an MIT license now?
m
What is the error?
c
Screenshot 2024-04-22 at 16.57.14.png
j
Probably the way that it has been written, not the type of license
this 1
c
where can i find a list of acceptable licenses?
m
That's where I was leading
replace:
Copy code
licence: "['GPL v3']"
by:
Copy code
licence: ["GPL v3"]
in 
modules/nf-core/peka/meta.yml
, and that should do the trick
👍🏻 1
c
ahhhhhhhhhhhhhh gotcha
why is chris cheshire the code owner for the module?
👀 1
m
what the PR?
c
i contributed the module and this PR but it says chris cheshire has to review the change because he's the code owner
m
Oh I see
the phrasing is probably misleading, sorry about that
We generated this file to help us automatically request reviews from people having contributed to the code before: https://github.com/nf-core/modules/blob/master/.github/CODEOWNERS#L717
c
ahhhh i see, but because the others arent nf-core members they dont get pinged? and this is just taken from the maintainers section
m
If I remember well, (@Edmund can you confirm there), just one of the contributors should be requested
and the codeowners have been generated based on the authors/maintainers declared in the meta.yml
e
Little column A, Little column B? They definitely need to be in the nf-core org to get pinged, it should also rotate who gets requested automatically!
👍 1
m
Thanks for the reply @Edmund
c
nice one - thanks both
p
So the others didn't get pinged because it rotates ☝🏻
Open in Slack
PreviousNext
Powered by