I am a bit stuck on the wittyer module since I am ...
# variantbenchmarking
f
I am a bit stuck on the wittyer module since I am still unsure how we will access the docker image but I worked a bit on the module and edited the meta.yaml file and so on. https://github.com/nf-core/modules/pull/5171
n
Can you add the
Dockerfile
to the module? I'll take a look in a minute
@Maxime Garcia could you add that container to the nf-core quay organization? 😛
f
I could copy the
Dockerfile
that is provided by Illumina for example
m
Is the container build and pushed anywhere already?
k
I have it
But I am a bit confused whether that is the most elegant way since Illumina provides the Dockerfile and also keeps it updated?
Or do we just manually update the image and push each time they update theirs?
k
updating dockerfile does not mean they do update image
we do create our own image since they dont keep the images updated 😄
m
Copy code
docker pull kubran/wittyer:0.3.3.0
docker tag kubran/wittyer:0.3.3.0 <http://quay.io/nf-core/wittyer:0.3.3.0|quay.io/nf-core/wittyer:0.3.3.0>
docker push <http://quay.io/nf-core/wittyer:0.3.3.0|quay.io/nf-core/wittyer:0.3.3.0>
f
I'll add a README then which holds the link to the original repo with the Illumina
Dockerfile
and the snippet to add it to the nf-core images. Does that make sense?
🤌🏻 1
👍 1
@Maxime Garcia Did you push it to quay.io?
m
try
docker pull <http://quay.io/nf-core/wittyer:0.3.3.0|quay.io/nf-core/wittyer:0.3.3.0>
😉
but yes
I did just what I send a couple of lines up
🎉 1
f
I always get
Copy code
Error response from daemon: unauthorized: access to the requested resource is not authorized
m
oooh
facepalm
of course
sorry my bad
I just forgot one important part
🧜‍♀️ 1
Make the image public
🎉 1
give me 5
👍 1
Done
f
Its working for me now party parrot
m
sorry about that
f
No worries. I added to the README that it needs to be public 👍
k
test with singularity 😄