https://nf-co.re logo
Join Slack
Powered by
Hello all, I need your guidance to properly transf...
# variantbenchmarking
k
Hello all, I need your guidance to properly transfer the draft pipeline I have here https://github.com/kubranarci/svbench to nf-core/variantbenchmarking . Should I start over a new fresh pipeline, or does it make sense to edit pipelines etc before the transfer?
and I have some nf-core violations over the modules etc 😅
😱 1
m
I'm guessing you're not an organisation
Could you transfer to me, so I transfer to nf-core?
k
It does not allow me to write your name 🧐
m
@maxulysse
?
k
sorry it does 😄
Cannot find new owner '@maxulysse'
oaky I needed to remove @ :D
it felt a bit sad, probably my hands were shaking
m
Just had a more in depth look, we might have a couple of issues
the first commit is not right, and we're missing a TEMPLATE branch
Do you mind if I force push to fix this?
k
I actually, started a "fresh" pipeline. I made changes to nf-core modules before 😞 I wanted to fix them
okay, maybe it would be better to go over from what we have
m
no worries, I'll keep all, we just might lose a bit of history, which is why I'd rather do it ASAP
k
okay, no problem then 😄
🎉 1
m
I'm on it
👍🏻 1
ok, we have a proper TEMPLATE branch
I used it to create 
master
The branch you worked on was 
main
right?
since I see a PR merge in it from dev
so I'll just use 
main
to create a new 
dev
k
dev was a bit ahead actually
m
ok
then I'll use dev for this
k
yeap, thank you
m
I'll delete main then
k
himm, why do you delete main?
dev was my developer brach, although main was the stable one
but I would like to apply the standards you have 😄
m
so unfortunately we still use master as the default main branch in nf-core
The main issue in the current repo is that the first commit should be created by nf-core tools for sync purpose
which is basically the TEMPLATE branch
k
okay 😄 good to know
m
So I'm sorry, it'll appear that I created the pipeline because the initial commits will be from me, but I just put your name in
I'm afraid I'm not skilled enough with git to keep the history and authorship
k
😄 I see the issue, no problem.
I can still continue working on dev branch right?
m
can you halt for now until I made the new one
otherwise given that the history is different it's going to be a mess
k
okay
m
ok
Done
Sorry for the delay
had a meeting in the middle
so we now have a new 
TEMPLATE
and a new 
master
that are the same, and it's basically just nf-core template
then on 
dev
we now have a new branch in which I copied over the files from the old dev, and kept some TEMPLATE update + fix names (svbench/benchmark -> variantbenchmarking)
It looked like files from 2 different pipelines were merged in this one
just to be sure, I've kept the previous versions of 
main
and 
dev
as 
main_old
and 
dev_old
I'd recommend to fork the nf-core repo from your side, and resume work from there
copy/pasting files (except from the 
.git/
folder) should do the trick
Don't hesitate to ping me if you need anything
k
Hey thank you! I will continue to work on this Monday /) have a great weekend
Open in Slack
Next
Powered by