Hello!! My colleges [<@U010JMYDPJB>] and I were a...
# bacass
d
Hello!! My colleges [@Sara Monzon] and I were a about to implement a nextflow workflow for bacterial assembly but I noticed that you already publish nf-core/bacass which covers most of the goals we initially propossed, however, some of them remains uncovered and may be great chance to evaluate them as a potential contributions/improvements for nf-core/bacass. Summarizing we had in mind to: • update modules • replace or sustitute a set of modules with already published nf-core/subworkflows. • allow single-end analysis • propose to add new modules for bacterial annotation, assmebly QC as well as adding new strategies for bacterial assembly. Since there are several proposals, is it okay if we open git-issues and work through it?
🎉 1
d
Hi there, that is an awesome idea. However, the plan was to continue working on nf-core/genomeassembler instead of bacass, i.e. that genomeassembler will be the successor of bacass. @Mahesh Binzer-Panchal is currently on leave and he started with most of the development in genomeassembler. I have currently not enough time and it looks genomeassembler might need a while until its ready for first analyses. So if you want to work on bacass, I would try to be supportive with reviews and discussions, if wanted.
🙌 1
Actually, the first hurdle seems to be the template update, see https://github.com/nf-core/bacass/pull/84, otherwise any code addition will fail to lint and new modules wouldnt be possible to add.
s
Hi @Daniel Straub! Thanks for the info! I'm trying to read about genomeassembler, the scope is to be able to assemble any type of sample? I'm I undertanding well?
about the template update, yes, we already have been looking into that, that's the first step for sure
👍 1
d
the scope is to be able to assemble any type of sample? I'm I undertanding well?
Yes
s
I've just more or less read the genomeassembler slack channel
loads of work there! Eukaria genomes are complicated xD
what would you recommend, would it be best to try to update bacass and include our contributions later to genomeassember once released or to directly contribute to genomeassembler development?
from our side, it would be easier and quickier to make the updates to bacass, and contribute to genomeassembler when is more advance 🙂 If you are available for reviews and discussion as suggested!
d
it would be easier and quickier to make the updates to bacass, and contribute to genomeassembler when is more advance
Yes, that seems a good way I think.
If you are available for reviews and discussion as suggested!
Yes, I'll try!
d
Many thanks @Daniel Straub 🙌.
Lets start updating the template. After that, I wil add the issues ;)
👍 1
j
for what its worth - i'll usually (since working with shortreads) run ragout on the scaffoldings before its annotated meaning • run bacass without annotation • reorganize the scaffoldings according to some refrences using ragout • annotate the files using bakta in case this is a direction you'd want to take, i might be able to contribute
d
Hi @János Winkler! , That would be great. So far, I started to update the workflow to the latest nf-core template version (https://github.com/nf-core/bacass/issues/85). If you have previous experience in nf-core template updates I would also appreciate your input 👉 #85. Once it is done, we can discuss potential feature enhancements 🙏🏻.
j
i never used such templates - i just put it together in a set of local pipelines but i try to read into the templates and with a bit of luck i'll understand whats happening there 🙈
d
Cool, I am following this guideline https://nf-co.re/docs/contributing/sync#resolving-major-conflicts So far, I am resolving major conflicts after merging the last template update into dev and also refactoring the code to follow the latest nf-core standards. I keep you in track of the progress I make in #85
j
thank you
😉 1
d
For me it often helps to check the latest template to understand the code better, see https://github.com/nf-core/tools/tree/2.9/nf_core/pipeline-template
d
• nf-core bacass template update (#86 plus #91) ✅