Armando Ytriago
04/23/2023, 6:21 AMDANGerous
04/23/2023, 6:31 AMDhia Gharsallaoui
04/24/2023, 8:13 AMThomas Chung
04/25/2023, 11:43 PMTariq Hasan
04/25/2023, 11:43 PMDhia Gharsallaoui
04/26/2023, 3:58 PMTariq Hasan
04/28/2023, 6:17 PMglobal_vars
or if you require the variable to be entered as an environment variable and read in through the EnvironmentVariableLoader
.
I was also curious about the naming for this variable. Would you like it to capitalized as ENV
similar to how the environment variables are treated when using the handlebar syntax or kept as env
similar to how the global variables are named?
Lastly, I wanted to clarify if the syntax should be {{ env_var('env') }}
or {{ var('env') }}
(assuming lower-case convention here).Dhia Gharsallaoui
04/28/2023, 11:53 PMXiaoyou Wang
04/28/2023, 11:54 PMDhia Gharsallaoui
05/04/2023, 7:27 AMJoseph Corrado
05/09/2023, 5:55 PMDhanush n
05/22/2023, 8:41 AMDhanush n
05/22/2023, 8:41 AMDhanush n
05/22/2023, 8:43 AMAnupam Kumar
05/31/2023, 6:53 AMVitor Fraga
06/29/2023, 3:43 PMJoseph Corrado
07/04/2023, 12:03 PM./scripts/init.sh mage_dev
The docker build was failing on the pip install -r requirements.txt
.
In particular, it was failing to build uamqp
, which it says is required to install pyproject.toml
based projects.
I tried removing the pyproject.toml
and poetry.lock
files in the root of mage-ai
and in mage-integrations
, but I still get the same error.
Is anyone else having this error? I can’t tell if it’s because my mac is the M2 on the ARM architecture, so it’s failing at the compile step.Joseph Corrado
07/04/2023, 12:14 PMDestination
base class, there are some methods that throw Exceptions
, saying that derived classes need to implement (test_connection
and export_batch_data
); I was wondering if maybe @abstractmethod
should be used here instead - the reason being communication; if i’m trying to add a new destination, it’s not obvious to me what methods need to be overridden; I had to control F for Exception('Subclasses
• it was difficult to navigate to <https://docs.mage.ai/data-integrations/destinations/add-new-destination> - I kept trying to navigate to <https://docs.mage.ai/data-integrations/sources/add-new-destination> from the page <https://docs.mage.ai/contributing/backend/overview>, but it was routing me to <https://docs.mage.ai/introduction/overview> (I was only able to easily access that link because I had bookmarked it)
• how are dependencies for mage_integrations
being handled? is it the one big requirements.txt
that everyone pip
installs when building the docker image? are there plans for using extras, so if someone is working on a pipeline that’s just using S3 and Snowflake, they don’t need bigquery, mysql and Couchbase SDKs?
• is there any support within Mage for asynchronous data reading/writing? And how does the interface for the base Connection
and Destination
classes support those?
• how are upsert
or write/read-many patterns handled? SQL-based destinations require you to implement build_insert_commands
, and NoSQL-like destinations push the responsibility down to the user to pass a valid query string - just looking for some guidance here about how the supported workflows and access patterns are managed for different connections and destinations:
◦ some SDKs support asynch, bulk, read/write-many, in addition to transactional CRUD - I wonder if we want to surface those optimized capabilities to users
◦ I know there’s batch and streaming workflows, but I suppose I’m just looking for more clear guidance in the docs for what contract connectors should adhere to here
Thanks!Holger Amort
07/07/2023, 11:49 PMHolger Amort
07/07/2023, 11:49 PMMatt
07/12/2023, 11:54 PMJoseph Corrado
07/30/2023, 5:52 PMrequirements.txt
in the mage_integrations
folder. I see that some of the code in mage_integrations
depends on pandas
, but I don’t see pandas
inside the requirements.txt
in the mage_integrations
folder.
Does the code in mage_integrations
use the same virtual environment created from the requirements.txt
in the root of the repo (so the same one as mage_ai
?).
How are people handling this for development? Do they use a single virtual environment for both mage_ai
and mage_integrations
?
Thanks!Joseph Corrado
07/31/2023, 12:12 AMsetup.py
, the lowest compatible version of Python is Python 3.6. I’m pretty sure this is incompatible with at least some of the dependencies in the requirements.txt
(like polars
- which looks like it requires at least 3.8; or we should pin the version of polars
); I ran into installation issues when trying to install the same dependencies with poetry
. And some of the dependencies in there have known security vulnerabilities and need to be updated (snyk
told me). I can put in a couple issues around these for the same.Joseph Corrado
07/31/2023, 12:30 AMpyproject.toml
specification for builds of mage_ai
and mage_integrations
?Ameenah lawal
08/01/2023, 12:41 PMChristopher Scholz
08/07/2023, 8:03 PMChristopher Scholz
08/08/2023, 7:27 PM/api/status
does this
• readinessProbe -> Checks whether the app is ready. This means, initial startup scripts have been run (e.g. git sync and database setup/migration). I guess for now the /api/status
will work, but is there a better one to use instead? If not should we add one?Christopher Scholz
08/10/2023, 8:04 PM&&
4. Most packages are not pinned, which could accidentally break the image and increase build time, as always the newest version is used, even if there is no need for updating it
5. In generell the Dockerfile doesnt follow the most best practices -> have a look e.g. at hadolint for checking the Dockerfile
6. The nonroot User should not have a fixed UID but rather any UID in the system range 100:65535 -> this can be done by adding --system
to the useradd
Would you rather have a single PR for all of it, or should we go one PR for each subtopic, so its easier for you to review and check?Slackbot
08/14/2023, 8:38 PM