This message was deleted.
# helpdesks
steep-balloon-41261
12/15/2023, 12:16 PMThis message was deleted.
b
broad-oil-45047
12/15/2023, 12:25 PMClicking the 'disconnect' button rerenders the component like 5-20 times and eventually sets both values to 'false' (usually videoEnabled is switched first). Something funky is going on here
broad-oil-45047
12/15/2023, 12:40 PMInternally, the Camera and Audio toggle buttons use TrackToggle.
I'm not sure if they're the cause of this issue, but these two spots seem suspect to me:
// useTrackToggle.ts
const enabled = useObservableState(enabledObserver, initialState ?? !!track?.isEnabled);
// TrackPublication.ts
get isEnabled(): boolean {
return true;
}
Always returning 'true' seems like an oversight to me.
p
polite-kilobyte-67570
12/15/2023, 1:08 PMHi, this got fixed recently and should work as expected in
v1.5.1b
broad-oil-45047
12/15/2023, 1:35 PMAccording to yarn.lock, we do have 1.5.1. Could these warnings (or rather their cause) disable the fix somehow?
broad-oil-45047
12/15/2023, 1:35 PMwarning " > @livekit/components-react@1.5.1" has incorrect peer dependency "livekit-client@^1.15.1".
warning " > @livekit/components-react@1.5.1" has incorrect peer dependency "react@>=18".
warning " > @livekit/components-react@1.5.1" has incorrect peer dependency "react-dom@>=18".
warning " > @livekit/components-react@1.5.1" has unmet peer dependency "tslib@^2.6.2".
warning "@livekit/components-react > @livekit/components-core@0.8.2" has incorrect peer dependency "livekit-client@^1.15.1".
warning "@livekit/components-react > @livekit/components-core@0.8.2" has unmet peer dependency "tslib@^2.6.2".
p
polite-kilobyte-67570
12/15/2023, 1:39 PMdefinitely makes sense to update livekit-client, too
b
broad-oil-45047
12/15/2023, 1:39 PMAh. The fix seems to be inside the prefab ControlBar component; we use our own custom one. But it should be easy to replicate it
p
polite-kilobyte-67570
12/15/2023, 1:39 PMah, yeah, that makes sense
b
broad-oil-45047
12/15/2023, 2:15 PMEven though it does not use useTrackToggle, clicking our disconnect button still prints 'user click: true' from this handler (which I copied from the fix to prefab ControlBar):
broad-oil-45047
12/15/2023, 2:15 PMconst cameraOnChange = useCallback(
(enabled: boolean, isUserInitiated: boolean) => {
console.log('enabled: ', enabled)
console.log('user click: ', isUserInitiated)
if (isUserInitiated) saveVideoInputEnabled(enabled)
},
[saveVideoInputEnabled],
)
broad-oil-45047
12/15/2023, 2:15 PM'enabled' is also 'false' here, which explains the reset issue on disconnect
p
polite-kilobyte-67570
12/15/2023, 2:17 PMcc @eager-zoo-16408
b
broad-oil-45047
12/15/2023, 2:17 PMour Disconnect button uses useDisconnectButton, and receives no props at all (so no onClick handler)
broad-oil-45047
12/15/2023, 2:31 PMSame happens for the audio handler: called with false when clicking disconnect button
broad-oil-45047
12/15/2023, 2:31 PMIt figures ofc, since it too uses useTrackToggle
p
polite-kilobyte-67570
12/15/2023, 2:33 PMare you spreading the html props that get returned from useTrackToggle on your custom implementation button ?
b
broad-oil-45047
12/15/2023, 2:34 PMYes. I was just beginning to think that might be the issue
p
polite-kilobyte-67570
12/15/2023, 2:37 PMI think I see a potential issue in our code
b
broad-oil-45047
12/15/2023, 2:59 PMWhat kind of issue? I'm trying to figure out how the wrong onClick method could fire, but so far I can only think that the className on our custom component could be the cause somehow. Here is our component, for reference:
broad-oil-45047
12/15/2023, 2:59 PMimport styled from 'styled-components'
const Button = styled.button`
.md-icon {
color: #fff;
font-size: 28px;
}
`
function ControlButton(props) {
return (
<Button className="lk-button" {...props}>
{props.children}
</Button>
)
}
export default ControlButton
p
polite-kilobyte-67570
12/15/2023, 3:09 PMare you calling the
togglepolite-kilobyte-67570
12/15/2023, 3:09 PMb
broad-oil-45047
12/15/2023, 3:16 PMAs far as I can tell, we don't call it anywhere
p
polite-kilobyte-67570
12/15/2023, 3:38 PMhm. could you provide a minimal reproduction repository?
b
broad-oil-45047
12/15/2023, 3:41 PMI'm not sure how to do it, given all the stuff that we use... I can ask my colleague, who did most of the implementation, but it will have to wait until Monday
p
polite-kilobyte-67570
12/15/2023, 3:42 PMsure, no rush. thanks!
b
broad-oil-45047
12/15/2023, 3:45 PMFWIW, I tried changing the className, but it didn't help. so the issue is likely with the toggle function. I'll get back to you on Monday
👍 1
broad-oil-45047
12/18/2023, 9:48 AMMy colleague is investigating this now; will report back with any results
broad-oil-45047
12/22/2023, 12:58 PMUpdate: in the end, we 'resolved' this issue by removing the option to persist the settings; we now take them from meeting-type-specific defaults instead. This was better for our use-case anyway, so we likely won't spend more time on this, unfortunately
👍 1