https://livekit.io logo
Join Slack
Powered by
This message was deleted.
# sdk-rust
s
This message was deleted.
w
using the 0.1.3 release of the sdk
d
looks like it's this issue. I think we should disable ffmpeg in our webrtc builds? wdyt @boundless-energy-78552 @freezing-lifeguard-43174?
b
Mmh this means we will not support h264 on Windows and Linux
w
i did try to disable ffmpeg with rtc_use_h264=false, that didn't help. i may be missing another way to completely remove it. if so that would be fine for my use case and i'd be happy to hack the build args myself
b
oh really? rtc_use_h264 should completely remove ffmpeg 👀
w
... i'll try again
b
I can double check
w
retried, still fails for me
b
You’re using LK_CUSTOM_WEBRTC?
I’ll try to reproduce it, can you send a small project that uses ffmpeg-next
w
no, i just changed the build_windows script in webrtc-sys
b
oh
this isn’t sufficient, by default webrtc-sys will download a pre-compiled version of libwebrtc on GH
you need to export LK_CUSTOM_WEBRTC to the location of your build
w
on 0.1.3? i saw that in main but thought it was new
b
Mmh maybe you can use upstream for now, I’m planning to release v0.2.0 this week
w
ok i'll figure it out, thanks for the pointers
(separate note - could you pls remove the explicit thiserror version from livekit-protocol, i can't use main directly due to that)
b
Yes sure, this is a mistake, gonna fix that
w
unfortunately i can't get main to build. i forked the repo, set rtc_use_h264=false in the windows script and reran the webrtc build action on github, then changed the download location to ref the artifacts produced, i think that much has worked. but i get errors locally which look like cxx bindgen. i've attached the log in case it's something you recognise. i'm happy to wait a few days for a release though. thanks for your help so far
build.log
b
Looks like some headers are missing, can you send me your GH actions logs?
w
i do see the missing headers in the win x64 artifact
locally i only saw them in debug folders under target, i'm just running a clean / build to see if that was from building against 0.1.3 previously or if they somehow ended up in the wrong place
the error is in the file i'm hovering, the "missing" file is present just above it
maybe time to burn my computer
😆 1
b
oh wow, weird, maybe the path is too long for Windows?
It means it is finding the header just above the missing one 🤔
w
i'll build it from a shorter path
i think you're right, it's just over 256 chars
i'm getting path too long while extracting the zip, with project root c:\short\
trying to extract to 
C:\short\target\release\build\scratch-6174fff5e9b4981b\out\livekit_webrtc\livekit\webrtc-win-x64-release-webrtc-d5ec6fa\webrtc-win-x64-release
finally after replacing scratch_path in the build/lib.rs with a shorter path, it all works. ffmpeg has been removed and my avformat_open calls work alongside livekit
thank you very much indeed
🙏 1
b
Hey @wooden-controller-23004, is it possible to receive a minimal reproducible example of what you did to do this issue? I know you disabled h264 but I’m curious If I can make it work with ffmpeg-next while still using rtc_use_h264=true
w
I’ll put something together
b
Thanks a lot 🙏
w
Open in Slack
PreviousNext
Powered by